You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/08 02:03:32 UTC

[GitHub] [iotdb] jt2594838 commented on a change in pull request #2635: [IOTDB-1148]fix the client leak of client pool&use remote schema cache when check timeseries exist or not

jt2594838 commented on a change in pull request #2635:
URL: https://github.com/apache/iotdb/pull/2635#discussion_r571741748



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -393,6 +414,10 @@ public synchronized MeasurementMNode get(PartialPath key) {
         return null;
       }
     }
+
+    public synchronized boolean containsKey(PartialPath key) {
+      return cache.containsKey(key);
+    }

Review comment:
       Is it necessary to mix synchronized and lock?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org