You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/06/22 11:33:00 UTC
[jira] [Commented] (HADOOP-14568) GenericTestUtils#waitFor missing
parameter verification
[ https://issues.apache.org/jira/browse/HADOOP-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059207#comment-16059207 ]
Steve Loughran commented on HADOOP-14568:
-----------------------------------------
Can you define the error strings as {{public static final}} in GTU, then use the same strings in your tests; guarantees consistent text. Also, you can use {{assertExceptionContains}} to validate exception string contents, or even use {{LambdaTestUtils.intercept()}} to execute the failing clause and validate the result
> GenericTestUtils#waitFor missing parameter verification
> -------------------------------------------------------
>
> Key: HADOOP-14568
> URL: https://issues.apache.org/jira/browse/HADOOP-14568
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0-alpha3
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HADOOP-14568.001.patch
>
>
> GenericTestUtils#waitFor missed the parameters verification. This will lead the method ran error or meanless. This point was suggested from this [comment|https://issues.apache.org/jira/browse/HDFS-11711?focusedCommentId=16039292&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16039292].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org