You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/24 07:15:11 UTC
[GitHub] [spark] HeartSaVioR commented on a change in pull request #26234:
[SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
HeartSaVioR commented on a change in pull request #26234: [SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
URL: https://github.com/apache/spark/pull/26234#discussion_r338414003
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
##########
@@ -73,7 +73,7 @@ class AllExecutionsPageSuite extends SharedSparkSession with BeforeAndAfter {
map.put("failed.sort", Array("duration"))
when(request.getParameterMap()).thenReturn(map)
val html = renderSQLPage(request, tab, statusStore).toString().toLowerCase(Locale.ROOT)
- assert(!html.contains("IllegalArgumentException"))
+ assert(!html.contains("illegalargumentexception"))
Review comment:
So the problem was that the assertion effectively doesn't verify anything - finding upper&lower string from lowercased string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org