[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1850: ci: cron ci must use the logical AND condition

["Chever-John (via GitHub)" <gi...@apache.org>]

Chever-John commented on code in PR #1850:
URL: https://github.com/apache/apisix-ingress-controller/pull/1850#discussion_r1218858974


##########
.github/workflows/e2e-test-ci-v2-cron-dev.yml:
##########
@@ -26,19 +26,14 @@ on:
     branches:
       - master
       - v1.6.0
-  pull_request:
-    branches:
-      - master
-      - v1.6.0
-    types: [opened, synchronize, reopened, review_requested]
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}-dev
+  group: ${{ github.workflow }}-dev
   cancel-in-progress: true
 
 jobs:
   changes:
-    if: ${{ (!github.event.pull_request.draft || github.event.schedule == '0 0 * * *') }}
+    if: ${{ github.event.schedule == '0 0 * * *') }}

Review Comment:
   Can I refer to any file?
   Is this line used to run ci at regular intervals?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org