You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/10/23 23:32:37 UTC

Re: Review Request 39492: Added status endpoint for quota master endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 9:32 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs (updated)
-----

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review105340
-----------------------------------------------------------



src/master/quota_handler.cpp (line 239)
<https://reviews.apache.org/r/39492/#comment163899>

    Have you considered defining a protobuf instead of manually constructing this?


- Joseph Wu


On Oct. 23, 2015, 3:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 3:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 338
> > <https://reviews.apache.org/r/39492/diff/4/?file=1131960#file1131960line338>
> >
> >     s/Status/status
> >     Do you think it makes sense to add `request.body`.
> 
> Joerg Schad wrote:
>     Considered adding request body, but as of right now the body is empty, or?

I'm thinking about the evolution of the request. Maybe it makes sense to add URL parameters? Will people be using extra flags? On the other side we can add it later. Dropping the issue.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107176
-----------------------------------------------------------


On Nov. 19, 2015, 3:19 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 338
> > <https://reviews.apache.org/r/39492/diff/4/?file=1131960#file1131960line338>
> >
> >     s/Status/status
> >     Do you think it makes sense to add `request.body`.

Considered adding request body, but as of right now the body is empty, or?


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107176
-----------------------------------------------------------


On Nov. 19, 2015, 12:44 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107176
-----------------------------------------------------------



include/mesos/quota/quota.proto (line 55)
<https://reviews.apache.org/r/39492/#comment166166>

    What is your message here?



src/master/quota_handler.cpp (line 338)
<https://reviews.apache.org/r/39492/#comment166164>

    s/Status/status
    Do you think it makes sense to add `request.body`.



src/master/quota_handler.cpp (lines 348 - 349)
<https://reviews.apache.org/r/39492/#comment166162>

    We insert a line between code and a comment. Alternatively, you can swap them. However, IMO the best is to remove L347 and insert a line here.



src/master/quota_handler.cpp (line 354)
<https://reviews.apache.org/r/39492/#comment166161>

    Newline


- Alexander Rukletsov


On Nov. 19, 2015, 12:44 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111565
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39211, 39018, 39102, 36913, 38059, 39285, 38110, 40342, 40351, 40396, 39223, 39492]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 7:02 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111596
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十二月 22, 2015, 9:40 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated 十二月 22, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review112665
-----------------------------------------------------------

Ship it!


- Joris Van Remoortere


On Dec. 22, 2015, 9:40 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 9:40 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-4013
    https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs
-----

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in Review 39614.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 8:38 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-4013
    https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs
-----

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing (updated)
-------

Tests are in Review 39614.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Dec. 21, 2015, 10:22 p.m., Guangya Liu wrote:
> > I assume that you will have another RR to cover the unit test, right?

Yes, just updated the description (as we removed the dependency and there is no next review anymore). Thanks!


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
-----------------------------------------------------------


On Dec. 22, 2015, 8:38 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 8:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in Review 39614.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111547
-----------------------------------------------------------

Ship it!


I assume that you will have another RR to cover the unit test, right?

- Guangya Liu


On 十二月 21, 2015, 7:02 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated 十二月 21, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 7:02 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Changes
-------

Adressed comments.


Bugs: MESOS-4013
    https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review111507
-----------------------------------------------------------

Ship it!



src/master/master.hpp (line 945)
<https://reviews.apache.org/r/39492/#comment171708>

    "quota settings" sounds like a new term we haven't used before. Let's be repetitive, but predictable. How about "Returns a list of set quotas".
    
    If you have something in mind how the response will be extended, feel free to add a `TODO`.



src/master/quota_handler.cpp (line 474)
<https://reviews.apache.org/r/39492/#comment171709>

    s/entry/an entry?


- Alexander Rukletsov


On Dec. 21, 2015, 2:56 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 2:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
>   src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 2:56 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-4013
    https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 03e816dcd4dead8326731ac221df7354c0610fed 
  src/master/master.hpp 8af82a0bbc2038e18180136c82cbaeeacc7b3526 
  src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 9:34 a.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-4013
    https://issues.apache.org/jira/browse/MESOS-4013


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 25, 2015, 3:50 p.m., Alexander Rukletsov wrote:
> > Please adjust the JIRA ticket: MESOS-4013.

Done.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review108007
-----------------------------------------------------------


On Dec. 16, 2015, 9:34 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 9:34 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4013
>     https://issues.apache.org/jira/browse/MESOS-4013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review108007
-----------------------------------------------------------


Please adjust the JIRA ticket: MESOS-4013.

- Alexander Rukletsov


On Nov. 19, 2015, 4:06 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 4:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 4:06 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107185
-----------------------------------------------------------



src/master/quota_handler.cpp (line 347)
<https://reviews.apache.org/r/39492/#comment166184>

    let's `static_cast` to `int` explicitly


- Alexander Rukletsov


On Nov. 19, 2015, 3:19 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 3:19 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
-------

Added status handling for quota master endpoint.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 12:44 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description (updated)
-------

Added status handling for quota master endpoint.


Diffs
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 

Diff: https://reviews.apache.org/r/39492/diff/


Testing (updated)
-------

Tests are in next Review.


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 12:43 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
-------

Added status handling for quota master endpoint.
Tests are in next Review.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 

Diff: https://reviews.apache.org/r/39492/diff/


Testing (updated)
-------

Test


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 195
> > <https://reviews.apache.org/r/39492/diff/3/?file=1126166#file1126166line195>
> >
> >     Am I right that there is another way to achieve the same:
> >     ```
> >     status.mutable_guarantees()->Add()->CopyFrom(quotaInfo.info);
> >     ```
> >     
> >     Do you know what the difference is and what approach is preferable?

Afaik they are equivalent. I would use Add() in cases where have the object anyhow and do not have to get it via mutable_X(). See for example in resources.cpp "resources.Add()->CopyFrom(that)". In cases where I only have access to a sorrounding object (i.e status in this case) I use add_x().


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107157
-----------------------------------------------------------


On Nov. 16, 2015, 1:13 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Nov. 19, 2015, 10:39 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 195
> > <https://reviews.apache.org/r/39492/diff/3/?file=1126166#file1126166line195>
> >
> >     Am I right that there is another way to achieve the same:
> >     ```
> >     status.mutable_guarantees()->Add()->CopyFrom(quotaInfo.info);
> >     ```
> >     
> >     Do you know what the difference is and what approach is preferable?
> 
> Joerg Schad wrote:
>     Afaik they are equivalent. I would use Add() in cases where have the object anyhow and do not have to get it via mutable_X(). See for example in resources.cpp "resources.Add()->CopyFrom(that)". In cases where I only have access to a sorrounding object (i.e status in this case) I use add_x().

Totally makes sense to me. Thanks!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107157
-----------------------------------------------------------


On Nov. 19, 2015, 12:44 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107157
-----------------------------------------------------------



include/mesos/quota/quota.proto (line 56)
<https://reviews.apache.org/r/39492/#comment166120>

    I think `guarantees` is not a good name, because quota can be more than just guarantee. Imagine `status.guarantees[0].limit`. How about naming it `infos`?



src/master/quota_handler.cpp (lines 190 - 191)
<https://reviews.apache.org/r/39492/#comment166124>

    Do you want to add a check here similar to `set()`?
    
    ```
      // Check that the request type is GET which is guaranteed by the master.
      CHECK_EQ("GET", request.method);
    ```



src/master/quota_handler.cpp (line 194)
<https://reviews.apache.org/r/39492/#comment166122>

    s/quotaInfo/quota



src/master/quota_handler.cpp (line 195)
<https://reviews.apache.org/r/39492/#comment166121>

    Am I right that there is another way to achieve the same:
    ```
    status.mutable_guarantees()->Add()->CopyFrom(quotaInfo.info);
    ```
    
    Do you know what the difference is and what approach is preferable?



src/master/quota_handler.cpp (line 198)
<https://reviews.apache.org/r/39492/#comment166123>

    Excessive empty line


- Alexander Rukletsov


On Nov. 16, 2015, 1:13 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Nov. 16, 2015, 7:01 p.m., Joseph Wu wrote:
> > include/mesos/quota/quota.proto, lines 54-57
> > <https://reviews.apache.org/r/39492/diff/3/?file=1126164#file1126164line54>
> >
> >     I noticed that the other endpoints do not take `QuotaInfo` objects; but instead take a `Resources` custom string/object.
> >     
> >     Since the internal representation of quota is different than the external representation, are you sure you want to expose the internal representation here?

As this protobuf is never directly exposed (only via json), I feel this is ok here. Also QuotaInfo is basically a role + Resources so we would redefine a similar message here.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review106701
-----------------------------------------------------------


On Nov. 16, 2015, 1:13 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review106701
-----------------------------------------------------------



include/mesos/quota/quota.proto (lines 54 - 57)
<https://reviews.apache.org/r/39492/#comment165433>

    I noticed that the other endpoints do not take `QuotaInfo` objects; but instead take a `Resources` custom string/object.
    
    Since the internal representation of quota is different than the external representation, are you sure you want to expose the internal representation here?



src/master/quota_handler.cpp (lines 191 - 194)
<https://reviews.apache.org/r/39492/#comment165434>

    Consider putting this before the loop:
    
    ```
    status.mutable_guarantees()->Reserve(master->quotas.size());
    ```


- Joseph Wu


On Nov. 16, 2015, 5:13 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 5:13 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 1:13 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
-------

Added status handling for quota master endpoint.
Tests are in next Review.


Diffs (updated)
-----

  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103934
-----------------------------------------------------------



src/master/quota_handler.cpp (line 246)
<https://reviews.apache.org/r/39492/#comment162044>

    indent?


- Guangya Liu


On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated 十月 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.

> On Oct. 25, 2015, 3:28 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, line 237
> > <https://reviews.apache.org/r/39492/diff/2/?file=1105415#file1105415line237>
> >
> >     Can you please add a new test case for this? You can refer to https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699 as a reference

Check the next patch in the chain (i.e. https://reviews.apache.org/r/39614/) :-).


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
-----------------------------------------------------------


On Oct. 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
-----------------------------------------------------------


Where did you set this endpoint of quota?


src/master/quota_handler.cpp (line 237)
<https://reviews.apache.org/r/39492/#comment162041>

    Can you please add a new test case for this? You can refer to https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699 as a reference


- Guangya Liu


On 十月 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated 十月 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review106541
-----------------------------------------------------------



src/master/quota_handler.cpp (line 239)
<https://reviews.apache.org/r/39492/#comment165251>

    Good point especially after looking at your status endpoint for maintenance primitives (37364). Will add that.


- Joerg Schad


On Oct. 23, 2015, 10:34 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 10:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> Tests are in next Review.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 39492: Added status endpoint for quota master endpoint.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.


Bugs: MESOS-3073
    https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description (updated)
-------

Added status handling for quota master endpoint.
Tests are in next Review.


Diffs
-----

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
-------

Test output: {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad