You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:58:29 UTC

[GitHub] [spark] zwangsheng commented on a change in pull request #32708: [WIP] [SPARK-35572] [K8S] add hostNetwork feature to executor

zwangsheng commented on a change in pull request #32708:
URL: https://github.com/apache/spark/pull/32708#discussion_r642291731



##########
File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
##########
@@ -67,6 +67,14 @@ elif ! [ -z ${SPARK_HOME+x} ]; then
   SPARK_CLASSPATH="$SPARK_HOME/conf:$SPARK_CLASSPATH";
 fi
 
+# when user want to formulate the IP they need, they can use this conf to post host
+if ! [ -z "${SPARK_EXECUTOR_POD_IP_OVERWRITE}" ]; then

Review comment:
       it is a executor pod env, maybe we should describe it alone like ENV_DRIVER_URL？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org