You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/10 22:32:24 UTC

[GitHub] [tvm] zxybazh commented on pull request #11676: [FIX,METASCHEDULER] Fix tune_te

zxybazh commented on PR #11676:
URL: https://github.com/apache/tvm/pull/11676#issuecomment-1152780311

   Hi Tristan, thanks for looking into the code for issues. However I think the previous implementation was fine becauase:
   1. `tune_tir` supports tuning of PrimFunc directly. The test could work without the modification.
   2. The test was skipped because it's an integration test not because it's broken. We prefer unittests instead of integration tests in CI.
   
   May I ask if there's any particular reason that we might want to enable this test or put PrimFunc into an IRModule? If you prefer to enable this test I think it would be great if we create a unit test instead for your need : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org