You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/04/06 22:12:07 UTC
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/361
change find to _.find in index-editor-actions
for creating a view from an older view
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton test-fix-nightwatch-viewCreate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 5b950fe08b906689a6aa35733737d484dfe5b0b6
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-04-06T20:10:31Z
change find to _.find in index-editor-actions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/361#issuecomment-90278861
i think i fixed it
@garrensmith could you look at this, i changed the tests a bit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/361#discussion_r27839771
--- Diff: app/addons/documents/tests/actionsSpec.js ---
@@ -45,6 +45,8 @@ define([
params: { limit: 10 },
database: database
});
+
+ designDocs = designDocs.models;
--- End diff --
here specifically
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/361#discussion_r27839780
--- Diff: app/addons/documents/tests/actionsSpec.js ---
@@ -204,8 +206,8 @@ define([
params: { limit: 10 },
database: database
});
-
- designDoc = designDocs.first();
+ designDocs = designDocs.models;
--- End diff --
and here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/361#issuecomment-90462520
+1, I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: change find to _.find in index-edito...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/361#issuecomment-90251853
not working yet
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---