You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/03 16:33:49 UTC
[GitHub] [dubbo-go-samples] Lvnszn opened a new pull request #220: [WIP] Rft: reduce docker containers with one dockercompose file
Lvnszn opened a new pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220
reduce docker containers with one dockercompose file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] Lvnszn commented on a change in pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
Lvnszn commented on a change in pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220#discussion_r702366569
##########
File path: integrate_test/docker/docker-compose.yml
##########
@@ -0,0 +1,20 @@
+version: '3'
+
+services:
+ zookeeper:
+ image: zookeeper
+ ports:
+ - 2181:2181
+ restart: on-failure
+
+ nacos:
+ image: nacos/nacos-server:1.2.0
+ container_name: nacos-standalone
+ environment:
+ - PREFER_HOST_MODE=hostname
+ - MODE=standalone
+ ports:
+ - "8848:8848"
Review comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on a change in pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220#discussion_r703124833
##########
File path: integrate_test/dockercompose/docker-compose.yml
##########
@@ -0,0 +1,22 @@
+version: '3'
Review comment:
还需要增加下etcd的docker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220#discussion_r702348817
##########
File path: integrate_test/docker/docker-compose.yml
##########
@@ -0,0 +1,20 @@
+version: '3'
+
+services:
+ zookeeper:
+ image: zookeeper
+ ports:
+ - 2181:2181
+ restart: on-failure
+
+ nacos:
+ image: nacos/nacos-server:1.2.0
+ container_name: nacos-standalone
+ environment:
+ - PREFER_HOST_MODE=hostname
+ - MODE=standalone
+ ports:
+ - "8848:8848"
Review comment:
zk 的 ports 配置为啥没有引号？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220#discussion_r702348827
##########
File path: integrate_test/docker/docker-compose.yml
##########
@@ -0,0 +1,20 @@
+version: '3'
+
+services:
+ zookeeper:
+ image: zookeeper
+ ports:
+ - 2181:2181
Review comment:
为何端口这里配置两个？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] Lvnszn commented on a change in pull request #220: Rft: reduce docker containers with one dockercompose file
Posted by GitBox <gi...@apache.org>.
Lvnszn commented on a change in pull request #220:
URL: https://github.com/apache/dubbo-go-samples/pull/220#discussion_r703144863
##########
File path: integrate_test/dockercompose/docker-compose.yml
##########
@@ -0,0 +1,22 @@
+version: '3'
Review comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org