[GitHub] [samza] mynameborat commented on a change in pull request #1160: Transactional State [1/5]: Added Store Checkpoint API

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1160: Transactional State [1/5]: Added Store Checkpoint API
URL: https://github.com/apache/samza/pull/1160#discussion_r327284725
 
 

 ##########
 File path: samza-api/src/main/java/org/apache/samza/storage/kv/KeyValueStore.java
 ##########
 @@ -141,4 +144,9 @@ default void deleteAll(List<K> keys) {
    * Flushes this key-value store, if applicable.
    */
   void flush();
+
+  /**
+   * Checkpoint the store snapshot.
+   */
+  Optional<Path> checkpoint(String id);
 
 Review comment:
   Sure, please you make sure we throw an exception if transactional state is enabled w/ async commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services