[GitHub] [iceberg] rdblue commented on a change in pull request #2694: Core: Validate user provided split planning configs

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2694:
URL: https://github.com/apache/iceberg/pull/2694#discussion_r650441888



##########
File path: core/src/main/java/org/apache/iceberg/BaseTableScan.java
##########
@@ -223,20 +223,27 @@ public TableScan ignoreResiduals() {
     } else {
       splitSize = targetSplitSize();
     }
+    Preconditions.checkArgument(splitSize > 0, "Split size should be greater than zero. Found: %s", splitSize);

Review comment:
       We normally phrase exception messages like "Invalid split size (negative): %s". That says basically the same thing, but is shorter and follows the conventions we use elsewhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org