You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/11/04 18:13:10 UTC
Review Request 39939: Make docker_socket option support different
protocols.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821
Repository: mesos
Description
-------
Make docker_socket option support different protocols.
Diffs
-----
docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0
src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb
src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
Diff: https://reviews.apache.org/r/39939/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 39939: Make docker_socket option support different
protocols.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review105105
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39939]
All tests passed.
- Mesos ReviewBot
On Nov. 4, 2015, 5:13 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:13 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make docker_socket option support different protocols.
>
>
> Diffs
> -----
>
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0
> src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 39939: Make docker_socket option support different
protocols.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review107466
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 4, 2015, 5:13 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2015, 5:13 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make docker_socket option support different protocols.
>
>
> Diffs
> -----
>
> docs/configuration.md 195814cf918e018d8287113299163415b94ab09f
> src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0
> src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb
> src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
>
> Diff: https://reviews.apache.org/r/39939/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>