You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/17 00:10:41 UTC

[GitHub] [helix] desaikomal commented on a change in pull request #1988: Implement deactivate rest API

desaikomal commented on a change in pull request #1988:
URL: https://github.com/apache/helix/pull/1988#discussion_r828546218



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -243,6 +243,18 @@ public Response updateCluster(@PathParam("clusterId") String clusterId,
         }
         break;
 
+      case deactivate:
+        if (superCluster == null) {

Review comment:
       can empty string be possible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org