You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jim King <Ji...@simplivity.com> on 2016/06/14 12:30:54 UTC

Pull request backlog

We have 106 total open pull requests, some from 2014.  Every one of them that I looked at (that passed a build at the time) have merge conflicts.  We really need to get a handle on this.  I found some that have been marked as closed, fixed but the pull request is still open, like:

https://github.com/apache/thrift/pull/434/files

In other cases the PR build failed, and there are merge conflicts, so unless someone re-assesses the fix and re-submits it, it is not going to go anywhere.  Perhaps it would be best to close all pull requests older than January 1, 2016.  This would reduce the pull request count to about 40.  We could put a comment into each pull request outstanding indicating that they need to be rebased against the current master and resubmitted.  If after a couple weeks that doesn't happen those would be closed too.

We should have a process around managing this backlog of pull requests.  Perhaps if a pull request is not passing builds and goes idle for a month and it is not blocked by a systemic build issue, it is automatically closed?

[Description: Description: simplivity-lg-xsmall]
James E. King, III
Architect
8 Technology Drive, 2nd Floor
Westborough, MA 01581-1756
Ph: 855-SVT-INFO
---------------------------------------------------------------------------------------
PRIVACY STATEMENT:
This message is a PRIVATE communication.  This message and all attachments are a private communication sent by SimpliVity and are considered to be confidential or protected by privilege. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the information contained in or attached to this message is strictly prohibited.  Please notify the sender of the delivery error by replying to this message, and then delete it from your system.
---------------------------------------------------------------------------------------