[jira] [Commented] (SQOOP-936) Classwriter should check if columnNames generated are null before accessing them

["Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598006#comment-13598006 ] 

Jarek Jarcec Cecho commented on SQOOP-936:
------------------------------------------

It's a simple patch so I'm giving +1 here.
                
> Classwriter should check if columnNames generated are null before accessing them
> --------------------------------------------------------------------------------
>
>                 Key: SQOOP-936
>                 URL: https://issues.apache.org/jira/browse/SQOOP-936
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.2, 1.4.3
>         Environment: Netezza database tests
>            Reporter: Venkat Ranganathan
>            Assignee: Venkat Ranganathan
>            Priority: Minor
>              Labels: trivial
>             Fix For: 1.4.4
>
>         Attachments: SQOOP-936.patch
>
>
> If a table does not at the time of DROP, Netezza throws an exception but also sets the transaction as ignored (all changes through the connection will be ignored until the txn is either rollback or committed.   While adding more tests, I missed the rollback and the create table was ignored, and subsequently ClassWriter.cleanColNames() threw NPE.   I am fixing Netezza tests also, but we should check for this and throw a IOException instead of failing with NPE

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira