You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/04/08 22:46:11 UTC
[GitHub] [cassandra] maedhroz commented on a diff in pull request #1559: CASSANDRA-17524 shutdown gossip on drain trunk
maedhroz commented on code in PR #1559:
URL: https://github.com/apache/cassandra/pull/1559#discussion_r846527053
##########
src/java/org/apache/cassandra/concurrent/Stage.java:
##########
@@ -42,27 +42,34 @@
public enum Stage
{
- READ ("ReadStage", "request", DatabaseDescriptor::getConcurrentReaders, DatabaseDescriptor::setConcurrentReaders, Stage::multiThreadedLowSignalStage),
- MUTATION ("MutationStage", "request", DatabaseDescriptor::getConcurrentWriters, DatabaseDescriptor::setConcurrentWriters, Stage::multiThreadedLowSignalStage),
- COUNTER_MUTATION ("CounterMutationStage", "request", DatabaseDescriptor::getConcurrentCounterWriters, DatabaseDescriptor::setConcurrentCounterWriters, Stage::multiThreadedLowSignalStage),
- VIEW_MUTATION ("ViewMutationStage", "request", DatabaseDescriptor::getConcurrentViewWriters, DatabaseDescriptor::setConcurrentViewWriters, Stage::multiThreadedLowSignalStage),
- GOSSIP ("GossipStage", "internal", () -> 1, null, Stage::singleThreadedStage),
- REQUEST_RESPONSE ("RequestResponseStage", "request", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedLowSignalStage),
- ANTI_ENTROPY ("AntiEntropyStage", "internal", () -> 1, null, Stage::singleThreadedStage),
- MIGRATION ("MigrationStage", "internal", () -> 1, null, Stage::migrationStage),
- MISC ("MiscStage", "internal", () -> 1, null, Stage::singleThreadedStage),
- TRACING ("TracingStage", "internal", () -> 1, null, Stage::tracingStage),
- INTERNAL_RESPONSE ("InternalResponseStage", "internal", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedStage),
- IMMEDIATE ("ImmediateStage", "internal", () -> 0, null, Stage::immediateExecutor),
- PAXOS_REPAIR ("PaxosRepairStage", "internal", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedStage),
+ READ (false, "ReadStage", "request", DatabaseDescriptor::getConcurrentReaders, DatabaseDescriptor::setConcurrentReaders, Stage::multiThreadedLowSignalStage),
+ MUTATION (true, "MutationStage", "request", DatabaseDescriptor::getConcurrentWriters, DatabaseDescriptor::setConcurrentWriters, Stage::multiThreadedLowSignalStage),
+ COUNTER_MUTATION (true, "CounterMutationStage", "request", DatabaseDescriptor::getConcurrentCounterWriters, DatabaseDescriptor::setConcurrentCounterWriters, Stage::multiThreadedLowSignalStage),
+ VIEW_MUTATION (true, "ViewMutationStage", "request", DatabaseDescriptor::getConcurrentViewWriters, DatabaseDescriptor::setConcurrentViewWriters, Stage::multiThreadedLowSignalStage),
+ GOSSIP (true, "GossipStage", "internal", () -> 1, null, Stage::singleThreadedStage),
+ REQUEST_RESPONSE (false, "RequestResponseStage", "request", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedLowSignalStage),
+ ANTI_ENTROPY (false, "AntiEntropyStage", "internal", () -> 1, null, Stage::singleThreadedStage),
+ MIGRATION (false, "MigrationStage", "internal", () -> 1, null, Stage::migrationStage),
+ MISC (false, "MiscStage", "internal", () -> 1, null, Stage::singleThreadedStage),
+ TRACING (false, "TracingStage", "internal", () -> 1, null, Stage::tracingStage),
+ INTERNAL_RESPONSE (false, "InternalResponseStage", "internal", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedStage),
+ IMMEDIATE (false, "ImmediateStage", "internal", () -> 0, null, Stage::immediateExecutor),
+ PAXOS_REPAIR (false, "PaxosRepairStage", "internal", FBUtilities::getAvailableProcessors, null, Stage::multiThreadedStage),
;
public final String jmxName;
private final Supplier<ExecutorPlus> executorSupplier;
private volatile ExecutorPlus executor;
+ /* Set true if this executor should be gracefully shutdown before stopping
+ * the commitlog allocator. Tasks on executors that issue mutations may
+ * block indefinitely waiting for a new commitlog segment, preventing a
+ * clean drain/shutdown.
+ */
+ public final boolean shutdownBeforeCommitlog;
Review Comment:
nit: Might as well make it a JavaDoc comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org