You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2023/09/28 11:12:26 UTC
[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #7670: Don't add filters to projection in TableScan
Dandandan commented on code in PR #7670:
URL: https://github.com/apache/arrow-datafusion/pull/7670#discussion_r1339957196
##########
datafusion/optimizer/src/push_down_projection.rs:
##########
@@ -147,10 +147,6 @@ impl OptimizerRule for PushDownProjection {
if !scan.projected_schema.fields().is_empty() =>
{
let mut used_columns: HashSet<Column> = HashSet::new();
- // filter expr may not exist in expr in projection.
Review Comment:
This added filters to the projection since https://github.com/apache/arrow-datafusion/pull/5188
FYI @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org