You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/06 08:46:57 UTC
[GitHub] [spark] sarutak opened a new pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
sarutak opened a new pull request #34818:
URL: https://github.com/apache/spark/pull/34818
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR changes `dev-run-integration-tests.sh` to allow it to take a custom Dockerfile like #34790 did.
With this change, this script accepts `--docker-file` option, which takes a path to a custom Dockerfile.
```
$ ./dev/run-integration-tests.sh --docker-file /path/to/dockerfile
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
As of #34790, we can specify a custom Dockerfile by `spark.kubernetes.test.dockerFile` property when we run the K8s integration tests using Maven.
We can run the integration test via `dev-run-integration-tests.sh` but there is no way to specify a custom Dockerfile.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Confirmed that the K8s integration tests run with the following command using `Dockerfile.java17`.
```
cd resource-managers/kubernetes/integration-tests
./dev/dev-run-integration-tests.sh --docker-file ../docker/src/main/dockerfiles/spark/Dockerfile.java17
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763229764
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -150,7 +150,10 @@ fi
if [ -n "$DOCKER_FILE" ];
then
- properties=( ${properties[@]} -Dspark.kubernetes.test.dockerFile=$(realpath $DOCKER_FILE) )
+ properties=(
+ ${properties[@]}
+ -Dspark.kubernetes.test.dockerFile=$(
+ python3 -c "import os.path; print(os.path.realpath(\"$DOCKER_FILE\"))") )
Review comment:
@sarutak We should use `realpath` consistently in our Spark bash code.
It seems that the root cause is that
1) You can a relative path via realpath in some directory
2) And, we moved to another directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987262205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50439/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988618789
**[Test build #146007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146007/testReport)** for PR 34818 at commit [`b599191`](https://github.com/apache/spark/commit/b599191bb34c4acf60d0309733d2b34b4e1fdeb4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763224654
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Python's `os.path.realpath` should work on both Linux and macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987019417
**[Test build #145958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145958/testReport)** for PR 34818 at commit [`26eca41`](https://github.com/apache/spark/commit/26eca4182c3a8f1e26842beba6880bda6704356e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986599883
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50421/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763227064
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
No~ It's Spark function in `utils.sh`.
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
No~ It's Spark bash function in `utils.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987124431
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50432/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763159377
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Hmm, `realpath` seems not to be a standard command. I tested on Pop!_OS 20.04.
I'll look for another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987142511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986636216
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50421/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763229764
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -150,7 +150,10 @@ fi
if [ -n "$DOCKER_FILE" ];
then
- properties=( ${properties[@]} -Dspark.kubernetes.test.dockerFile=$(realpath $DOCKER_FILE) )
+ properties=(
+ ${properties[@]}
+ -Dspark.kubernetes.test.dockerFile=$(
+ python3 -c "import os.path; print(os.path.realpath(\"$DOCKER_FILE\"))") )
Review comment:
@sarutak We should use `realpath` consistently in our Spark bash code.
It seems that the root cause was that
1) You can a relative path via realpath in some directory
2) And, we moved to another directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987009266
**[Test build #145958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145958/testReport)** for PR 34818 at commit [`26eca41`](https://github.com/apache/spark/commit/26eca4182c3a8f1e26842beba6880bda6704356e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987142511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987184648
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50439/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988693670
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986573639
**[Test build #145947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145947/testReport)** for PR 34818 at commit [`8072b13`](https://github.com/apache/spark/commit/8072b13d037cc60603d7dcdb83f61150f46332a6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986561307
**[Test build #145947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145947/testReport)** for PR 34818 at commit [`8072b13`](https://github.com/apache/spark/commit/8072b13d037cc60603d7dcdb83f61150f46332a6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987019699
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145958/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987142083
**[Test build #145963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145963/testReport)** for PR 34818 at commit [`167b681`](https://github.com/apache/spark/commit/167b681496eaea4a98c4c973bf479c1639863179).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763231699
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Ah, Linux has `realpath` command (coreutils) but we have own `realpath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987009266
**[Test build #145958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145958/testReport)** for PR 34818 at commit [`26eca41`](https://github.com/apache/spark/commit/26eca4182c3a8f1e26842beba6880bda6704356e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988618789
**[Test build #146007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146007/testReport)** for PR 34818 at commit [`b599191`](https://github.com/apache/spark/commit/b599191bb34c4acf60d0309733d2b34b4e1fdeb4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988704933
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988704933
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986654984
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50421/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987222890
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50439/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763155385
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Does this work? I'm testing your PR and hit the following.
```
$ cd resource-managers/kubernetes/integration-tests
$ ./dev/dev-run-integration-tests.sh --docker-file ../docker/src/main/dockerfiles/spark/Dockerfile.java17
++ git rev-parse --show-toplevel
+ TEST_ROOT_DIR=/Users/dongjoon/APACHE/spark-merge
+ DEPLOY_MODE=minikube
+ IMAGE_REPO=docker.io/kubespark
+ SPARK_TGZ=N/A
+ IMAGE_TAG=N/A
+ JAVA_IMAGE_TAG=
+ BASE_IMAGE_NAME=
+ JVM_IMAGE_NAME=
+ PYTHON_IMAGE_NAME=
+ R_IMAGE_NAME=
+ DOCKER_FILE=
+ SPARK_MASTER=
+ NAMESPACE=
+ SERVICE_ACCOUNT=
+ CONTEXT=
+ INCLUDE_TAGS=k8s
+ EXCLUDE_TAGS=
+ JAVA_VERSION=8
+ BUILD_DEPENDENCIES_MVN_FLAG=-am
+ HADOOP_PROFILE=hadoop-3.2
+ MVN=/Users/dongjoon/APACHE/spark-merge/build/mvn
++ /Users/dongjoon/APACHE/spark-merge/build/mvn help:evaluate -Dexpression=scala.binary.version
++ grep -v INFO
++ grep -v WARNING
++ tail -n 1
+ SCALA_VERSION=2.12
+ export SCALA_VERSION
+ echo 2.12
2.12
+ (( 2 ))
+ case $1 in
+ DOCKER_FILE=../docker/src/main/dockerfiles/spark/Dockerfile.java17
+ shift
+ shift
+ (( 0 ))
+ properties=(-Djava.version=$JAVA_VERSION -Dspark.kubernetes.test.sparkTgz=$SPARK_TGZ -Dspark.kubernetes.test.imageTag=$IMAGE_TAG -Dspark.kubernetes.test.imageRepo=$IMAGE_REPO -Dspark.kubernetes.test.deployMode=$DEPLOY_MODE -Dtest.include.tags=$INCLUDE_TAGS)
+ '[' -n '' ']'
+ '[' -n ../docker/src/main/dockerfiles/spark/Dockerfile.java17 ']'
+ properties=(${properties[@]} -Dspark.kubernetes.test.dockerFile=$(realpath $DOCKER_FILE))
++ realpath ../docker/src/main/dockerfiles/spark/Dockerfile.java17
./dev/dev-run-integration-tests.sh: line 153: realpath: command not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763227911
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Oh..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988653297
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763159377
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Hmm, `realpath` seems not to be a standard command. I tested on Pop!_OS 20.04 and CentOS 8.
I'll look for another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763231699
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
Ah, Linux has `realpath` built-in command (coreutils) but we have own `realpath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987019699
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145958/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987127414
**[Test build #145963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145963/testReport)** for PR 34818 at commit [`167b681`](https://github.com/apache/spark/commit/167b681496eaea4a98c4c973bf479c1639863179).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988994638
@dongjoon-hyun Thank you for your advice and review !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987124431
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50432/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763227064
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
No~ It's Spark bash function in `util.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r762801239
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -237,6 +244,13 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
</td>
<td><code>spark-r</code></td>
</tr>
+ <tr>
+ <td><code>spark.kubernetes.test.dockerFile</code></td>
Review comment:
This part is what I forgot to add in #34790 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986561307
**[Test build #145947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145947/testReport)** for PR 34818 at commit [`8072b13`](https://github.com/apache/spark/commit/8072b13d037cc60603d7dcdb83f61150f46332a6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986605752
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986605752
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145947/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34818:
URL: https://github.com/apache/spark/pull/34818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988629011
**[Test build #146007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146007/testReport)** for PR 34818 at commit [`b599191`](https://github.com/apache/spark/commit/b599191bb34c4acf60d0309733d2b34b4e1fdeb4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class PandasSQLStringFormatter(string.Formatter):`
* `class SQLStringFormatter(string.Formatter):`
* `case class ConvertTimezone(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987041381
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50432/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987111847
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50432/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r762802615
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -180,4 +190,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+(cd $TEST_ROOT_DIR; ./build/mvn install -pl resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG -Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]})
Review comment:
I noticed that all the examples of `dev-run-integration-tests.sh` in `integration-tests/README.md` don't work because `scala-style-config.xml` is not found in `integration-tests`.
This change is to resolve the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-986654984
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50421/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #34818:
URL: https://github.com/apache/spark/pull/34818#discussion_r763240284
##########
File path: resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -150,7 +150,10 @@ fi
if [ -n "$DOCKER_FILE" ];
then
- properties=( ${properties[@]} -Dspark.kubernetes.test.dockerFile=$(realpath $DOCKER_FILE) )
+ properties=(
+ ${properties[@]}
+ -Dspark.kubernetes.test.dockerFile=$(
+ python3 -c "import os.path; print(os.path.realpath(\"$DOCKER_FILE\"))") )
Review comment:
I didn't notice `realpath` in `util.sh` and I used `realpath` command which is installed on Linux.
OK, I'll use our own `realpath` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987127414
**[Test build #145963 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145963/testReport)** for PR 34818 at commit [`167b681`](https://github.com/apache/spark/commit/167b681496eaea4a98c4c973bf479c1639863179).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-987262205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50439/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988629337
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146007/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34818: [SPARK-37529][K8S][TESTS][FOLLOWUP] Allow dev-run-integration-tests.sh to take a custom Dockerfile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34818:
URL: https://github.com/apache/spark/pull/34818#issuecomment-988629337
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146007/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org