You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2011/02/18 23:06:38 UTC

[jira] Created: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Pig returns exit code 0 for the failed Pig script due to non-existing input directory
-------------------------------------------------------------------------------------

                 Key: PIG-1862
                 URL: https://issues.apache.org/jira/browse/PIG-1862
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.8.0
            Reporter: Richard Ding
            Assignee: Richard Ding
             Fix For: 0.9.0, 0.8.0
         Attachments: PIG-1862.patch

Test case:

{code}
a = load 'nonexisting.file';
b = filter a by $0 > 0;
c = group b by $0;
d = join c by $0, b by $0;
store d into 'output';
{code}

The script fails, but the return code is 0.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1862:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Patch committed to trunk.

> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.9.0, 0.8.0
>
>         Attachments: PIG-1862.patch, PIG-1862_1.patch, PIG-1862_1.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1862:
------------------------------

    Attachment: PIG-1862_1.patch

Rebase the patch against trunk.

> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0, 0.9.0
>
>         Attachments: PIG-1862.patch, PIG-1862_1.patch, PIG-1862_1.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996651#comment-12996651 ] 

Olga Natkovich commented on PIG-1862:
-------------------------------------

I am ok with this patch as the short-term fix for 0.8 However, we need to revisit this for 0.9 there are a couple of things in our current approach that seems strange to me:

(1) That now we log temp jobs that failed but not the ones that succeed
(2) That reporting an error is so tightly connected with reporting stats for the store


> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0, 0.9.0
>
>         Attachments: PIG-1862.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1862:
------------------------------

    Attachment: PIG-1862_1.patch

New patch for trunk that addresses review comments.

Output of test-patch:

{code}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 12 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{code}

> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0, 0.9.0
>
>         Attachments: PIG-1862.patch, PIG-1862_1.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005292#comment-13005292 ] 

Daniel Dai commented on PIG-1862:
---------------------------------

+1

> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0, 0.9.0
>
>         Attachments: PIG-1862.patch, PIG-1862_1.patch, PIG-1862_1.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (PIG-1862) Pig returns exit code 0 for the failed Pig script due to non-existing input directory

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996675#comment-12996675 ] 

Richard Ding commented on PIG-1862:
-----------------------------------

committed to branch-0.8

> Pig returns exit code 0 for the failed Pig script due to non-existing input directory
> -------------------------------------------------------------------------------------
>
>                 Key: PIG-1862
>                 URL: https://issues.apache.org/jira/browse/PIG-1862
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.8.0, 0.9.0
>
>         Attachments: PIG-1862.patch
>
>
> Test case:
> {code}
> a = load 'nonexisting.file';
> b = filter a by $0 > 0;
> c = group b by $0;
> d = join c by $0, b by $0;
> store d into 'output';
> {code}
> The script fails, but the return code is 0.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira