[GitHub] wvengen commented on a change in pull request #276: CB-14188: Add beforeload event, catching navigation before it happens

[GitBox <gi...@apache.org>]

wvengen commented on a change in pull request #276: CB-14188: Add beforeload event, catching navigation before it happens
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#discussion_r233077431
 
 

 ##########
 File path: src/android/InAppBrowser.java
 ##########
 @@ -1085,16 +1105,20 @@ public void onActivityResult(int requestCode, int resultCode, Intent intent) {
     public class InAppBrowserClient extends WebViewClient {
         EditText edittext;
         CordovaWebView webView;
+        boolean useBeforeload;
+        boolean waitForBeforeload;
 
         /**
          * Constructor.
          *
          * @param webView
          * @param mEditText
          */
-        public InAppBrowserClient(CordovaWebView webView, EditText mEditText) {
+        public InAppBrowserClient(CordovaWebView webView, EditText mEditText, boolean useBeforeload) {
             this.webView = webView;
             this.edittext = mEditText;
+            this.useBeforeload = useBeforeload;
 
 Review comment:
   (this is merged already, but perhaps my reply will serve as a reference)
   `waitForBeforeload` is the current state, whether we need to wait a call back from JS to really load next time it is encountered. `useBeforeload` indicates whether the `beforeload` event is used at all (see the end of `shouldOverrideUrlLoading`).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org