[GitHub] [pinot] Jackie-Jiang commented on pull request #8074: For DISTINCT_COUNT, automatically convert Set to HyperLogLog when cardinality is too high

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #8074:
URL: https://github.com/apache/pinot/pull/8074#issuecomment-1022630587


   > This changes the semantics of the function so that it is no longer a distinct count. I think it would be better to raise an error if the threshold is breached, which would educate the user to use `distinctcounthll` instead (this would also be documented clearly).
   
   Good point. We can definitely reject the query if it goes over the threshold, and make the threshold configurable.
   @kishoreg What's your opinion on this behavior? Reject or silently convert?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org