[GitHub] [airflow] kaxil opened a new pull request #5955: [AIRFLOW-5350] Fix bug in the num_retires field in BigQueryHook

[GitBox <gi...@apache.org>]

kaxil opened a new pull request #5955: [AIRFLOW-5350] Fix bug in the num_retires field in BigQueryHook
URL: https://github.com/apache/airflow/pull/5955
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5350
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   The `num_retries` extra is no set in old connections that were created before 1.10.4, for those fields it's value is None which causes the below error:
   
   From the StackOverflow Post:
   
   ```
    [2019-08-27 02:49:58,076] {cli.py:516} INFO - Running <TaskInstance: cadastro_remessas_paises2.gcs_to_bq 2019-08-27T02:42:43.970619+00:00 [running]> on host cadastroremessaspaises2gcstobq-78f1ea099c3b4e718ba707cb03ffda1e 
       [2019-08-27 02:49:58,136] {logging_mixin.py:95} INFO - [[34m2019-08-27 02:49:58,136[0m] {[34mdiscovery.py:[0m271} INFO[0m - URL being requested: GET [1mhttps://www.googleapis.com/discovery/v1/apis/bigquery/v2/rest[0m[0m 
       [2019-08-27 02:49:59,259] {logging_mixin.py:95} INFO - [[34m2019-08-27 02:49:59,259[0m] {[34mmy_functions_google.py:[0m2224} INFO[0m - Project not included in [1mdestination_project_dataset_table[0m: [1mcadastro_remessas.paises2[0m; using project "[1mbigdata-staging[0m"[0m 
       [2019-08-27 02:49:59,266] {logging_mixin.py:95} INFO - [[34m2019-08-27 02:49:59,266[0m] {[34mdiscovery.py:[0m867} INFO[0m - URL being requested: POST https://www.googleapis.com/bigquery/v2/projects/bigdata-staging/jobs?alt=json[0m 
       [2019-08-27 02:49:59,266] {taskinstance.py:1047} ERROR - unsupported operand type(s) for +: 'NoneType' and 'int' Traceback (most recent call last):   File "/usr/local/lib/python3.7/site-packages/airflow/models/taskinstance.py", line 922, in _run_raw_task
           result = task_copy.execute(context=context)   
           File "/airflow/dags/git/subfolder/my_functions_google.py", line 2502, in execute
           cluster_fields=self.cluster_fields)   
           File "/airflow/dags/git/subfolder/my_functions_google.py", line 1396, in run_load
           return self.run_with_configuration(configuration)   
           File "/airflow/dags/git/subfolder/my_functions_google.py", line 1414, in run_with_configuration
           .execute(num_retries=self.num_retries)   
           File "/usr/local/lib/python3.7/site-packages/googleapiclient/_helpers.py", line 130, in positional_wrapper
           return wrapped(*args, **kwargs)   
           File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 851, in execute
           method=str(self.method), body=self.body, headers=self.headers)   
           File "/usr/local/lib/python3.7/site-packages/googleapiclient/http.py", line 153, in _retry_request
           for retry_num in range(num_retries + 1): TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
   ```
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   * `TestBigQueryHookWithNumRetries.test_num_retries_is_not_none_by_default`
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services