You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/10/27 09:28:59 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3898: HDDS-7428. Calculate number of blocks to allocate on SCM
kaijchen opened a new pull request, #3898:
URL: https://github.com/apache/ozone/pull/3898
## What changes were proposed in this pull request?
Currently, AllocateBlock takes two major arguments: size and num. There are some problems in the current API:
1. For EC replication type, the allocated size for clients to write is `size` * `ec.numData` * `num`, which is not a good abstraction from the HDDS client's view.
2. It assumes all blocks are in same size. However, sometimes it's useful to let SCM allocate arbitrary size the client wants (e.g. when client know the key size in advance).
In this Jira, I wish to add a `requestedSize` field in the AllocateBlock RPC.
SCM will calculate how many blocks to allocate based on `requestedSize`,
and return size of each block allocated to client.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7428
## How was this patch tested?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3898: HDDS-7428. Calculate number of blocks to allocate on SCM
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3898:
URL: https://github.com/apache/ozone/pull/3898#issuecomment-1294729025
In Ozone weekly meeting, @ChenSammi mentioned the client might need to specify custom block size for compatibility with HDFS. So I have reused the `size` field in proto to denote the client specified block size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3898: HDDS-7428. Calculate number of blocks to allocate on SCM
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3898:
URL: https://github.com/apache/ozone/pull/3898#issuecomment-1303041759
Converted to draft to address compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen closed pull request #3898: HDDS-7428. Change AllocateBlock API for precise allocation and better abstraction
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen closed pull request #3898: HDDS-7428. Change AllocateBlock API for precise allocation and better abstraction
URL: https://github.com/apache/ozone/pull/3898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3898: HDDS-7428. Calculate number of blocks to allocate on SCM
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3898:
URL: https://github.com/apache/ozone/pull/3898#issuecomment-1293252667
Hi @JacksonYao287, this PR implements the idea of better AllocateBlock abstraction https://github.com/apache/ozone/pull/3882#pullrequestreview-1157514505.
It's still work in progress though (need to add tests and handle compatibility),
can you help review the API design first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org