You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/03/08 21:11:24 UTC
Review Request 57432: RANGER-1434: Enable Group Search First causes
issues when Enable Group Sync is disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57432/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1434
https://issues.apache.org/jira/browse/RANGER-1434
Repository: ranger
Description
-------
Made changes to the code to set "Enable Group Search First" to false when "Enable Group Sync" is set to false. Also updated unit tests accordingly.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java d839b39
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java b4c9065
Diff: https://reviews.apache.org/r/57432/diff/1/
Testing
-------
1. Ran unit tests successfully.
2. Also tried basic tests with OpenLDAP server.
Thanks,
Sailaja Polavarapu
Re: Review Request 57432: RANGER-1434: Enable Group Search First
causes issues when Enable Group Sync is disabled
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57432/#review168397
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On March 9, 2017, 1:22 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57432/
> -----------------------------------------------------------
>
> (Updated March 9, 2017, 1:22 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1434
> https://issues.apache.org/jira/browse/RANGER-1434
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Made changes to the code to set "Enable Group Search First" to false when "Enable Group Sync" is set to false. Also updated unit tests accordingly.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java d839b39
> ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java b4c9065
>
>
> Diff: https://reviews.apache.org/r/57432/diff/1/
>
>
> Testing
> -------
>
> 1. Ran unit tests successfully.
> 2. Also ran some basic tests with OpenLDAP server.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 57432: RANGER-1434: Enable Group Search First
causes issues when Enable Group Sync is disabled
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57432/
-----------------------------------------------------------
(Updated March 9, 2017, 1:22 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1434
https://issues.apache.org/jira/browse/RANGER-1434
Repository: ranger
Description
-------
Made changes to the code to set "Enable Group Search First" to false when "Enable Group Sync" is set to false. Also updated unit tests accordingly.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java d839b39
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java b4c9065
Diff: https://reviews.apache.org/r/57432/diff/1/
Testing
-------
1. Ran unit tests successfully.
2. Also ran some basic tests with OpenLDAP server.
Thanks,
Sailaja Polavarapu
Re: Review Request 57432: RANGER-1434: Enable Group Search First
causes issues when Enable Group Sync is disabled
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57432/
-----------------------------------------------------------
(Updated March 8, 2017, 11:37 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1434
https://issues.apache.org/jira/browse/RANGER-1434
Repository: ranger
Description
-------
Made changes to the code to set "Enable Group Search First" to false when "Enable Group Sync" is set to false. Also updated unit tests accordingly.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java d839b39
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java b4c9065
Diff: https://reviews.apache.org/r/57432/diff/1/
Testing
-------
1. Ran unit tests successfully.
2. Also ran some basic tests with OpenLDAP server.
Thanks,
Sailaja Polavarapu
Re: Review Request 57432: RANGER-1434: Enable Group Search First
causes issues when Enable Group Sync is disabled
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57432/
-----------------------------------------------------------
(Updated March 8, 2017, 9:11 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1434
https://issues.apache.org/jira/browse/RANGER-1434
Repository: ranger
Description
-------
Made changes to the code to set "Enable Group Search First" to false when "Enable Group Sync" is set to false. Also updated unit tests accordingly.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java d839b39
ugsync/src/test/java/org/apache/ranger/usergroupsync/TestLdapUserGroup.java b4c9065
Diff: https://reviews.apache.org/r/57432/diff/1/
Testing (updated)
-------
1. Ran unit tests successfully.
2. Also ran some basic tests with OpenLDAP server.
Thanks,
Sailaja Polavarapu