You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by tkruse <gi...@git.apache.org> on 2015/08/26 02:54:20 UTC
[GitHub] incubator-groovy pull request: Groovysh: Fix imports not working a...
GitHub user tkruse opened a pull request:
https://github.com/apache/incubator-groovy/pull/100
Groovysh: Fix imports not working at all in interpreter mode
Hi,
this is a bit embarassing. The interpreter mode introduced with Groovy 2.4 does not handle imports correctly. With the bug, it becomes impossible to import anything, as long as the shell is in interpreter mode. The fix is simple, since the interpreter mode merely missed to used the 'import' keyword, that I had stripped away for brevity from the list of imports.
I added a test which breaks if imports fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tkruse/incubator-groovy fix-groovysh-import
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-groovy/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit d869f2c60e4718b73c585e2d41212993a19d69f3
Author: Thibault Kruse <th...@gmx.de>
Date: 2015-08-26T00:46:27Z
Groovysh: Fix imports not working at all in interpreter mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: Groovysh: Fix imports not working a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-groovy/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---