You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/13 13:08:08 UTC
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5027: [ISSUE #5026] add timer message put result process
RongtongJin commented on code in PR #5027:
URL: https://github.com/apache/rocketmq/pull/5027#discussion_r969603271
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java:
##########
@@ -351,6 +351,21 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
response.setRemark(String.format("the message is illegal, maybe msg body or properties length not matched. msg body length limit %dB, msg properties length limit 32KB.",
this.brokerController.getMessageStoreConfig().getMaxMessageSize()));
break;
+ case WHEEL_TIMER_MSG_ILLEGAL:
+ response.setCode(ResponseCode.WHEEL_TIMER_MSG_ILLEGAL);
+ response.setRemark(String.format("the accurate delay message is illegal, delay time max limit %dms, or check props if setting TIMER_DEL_UNIQKEY or not",
Review Comment:
Maybe "timer message illegal, the delay time should not be bigger than the max delay; or if set del msg, the delay time should be bigger than the current time" better
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java:
##########
@@ -351,6 +351,21 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
response.setRemark(String.format("the message is illegal, maybe msg body or properties length not matched. msg body length limit %dB, msg properties length limit 32KB.",
this.brokerController.getMessageStoreConfig().getMaxMessageSize()));
break;
+ case WHEEL_TIMER_MSG_ILLEGAL:
+ response.setCode(ResponseCode.WHEEL_TIMER_MSG_ILLEGAL);
+ response.setRemark(String.format("the accurate delay message is illegal, delay time max limit %dms, or check props if setting TIMER_DEL_UNIQKEY or not",
+ this.brokerController.getMessageStoreConfig().getTimerMaxDelaySec() * 1000));
+ break;
Review Comment:
How about reusing ResponseCode.MESSAGE_ILLEGAL for WHEEL_TIMER_MSG_ILLEGAL?
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java:
##########
@@ -351,6 +351,21 @@ private RemotingCommand handlePutMessageResult(PutMessageResult putMessageResult
response.setRemark(String.format("the message is illegal, maybe msg body or properties length not matched. msg body length limit %dB, msg properties length limit 32KB.",
this.brokerController.getMessageStoreConfig().getMaxMessageSize()));
break;
+ case WHEEL_TIMER_MSG_ILLEGAL:
+ response.setCode(ResponseCode.WHEEL_TIMER_MSG_ILLEGAL);
+ response.setRemark(String.format("the accurate delay message is illegal, delay time max limit %dms, or check props if setting TIMER_DEL_UNIQKEY or not",
+ this.brokerController.getMessageStoreConfig().getTimerMaxDelaySec() * 1000));
+ break;
+ case WHEEL_TIMER_FLOW_CONTROL:
+ response.setCode(ResponseCode.WHEEL_TIMER_FLOW_CONTROL);
+ response.setRemark(String.format("or send message too much, triggered the flow control max num limit is %d or the current value is greater than %d and less than %d, trigger random flow control",
+ this.brokerController.getMessageStoreConfig().getTimerCongestNumEachSlot() * 2L, this.brokerController.getMessageStoreConfig().getTimerCongestNumEachSlot(), this.brokerController.getMessageStoreConfig().getTimerCongestNumEachSlot() * 2L));
+ break;
+ case WHEEL_TIMER_NOT_ENABLE:
+ response.setCode(ResponseCode.WHEEL_TIMER_NOT_ENABLE);
+ response.setRemark(String.format("accurate delay is not enabled, timerWheelEnable is %s",
+ brokerController.getMessageStoreConfig().isTimerWheelEnable()));
Review Comment:
How about reusing ResponseCode.SYSTEM_ERROR for WHEEL_TIMER_FLOW_CONTROL and WHEEL_TIMER_NOT_ENABLE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org