You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zzcclp (via GitHub)" <gi...@apache.org> on 2024/04/24 02:28:57 UTC
[PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
zzcclp opened a new pull request, #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513
## What changes were proposed in this pull request?
[CH] Fix the incorrect transformer for the round function with the decimal data type.
When transforming the round function with the decimal data type, it only transformers the `child` expression, but missing the `scale` expression, which will lead to the incorrect results when executing the `round(decimal_data, x)`.
Close #5512.
(Fixes: #5512)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074917200
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074666068
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2076001325
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_04_24_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_04_23_2024_fd2519a2b_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>36.07</font></td>
<td><font color=#F92663>36.36</font></td>
<td><font color=#F92663>0.281</font></td>
<td><font color=#F92663>100.78%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>27.37</font></td>
<td><font color=#6F9915>24.01</font></td>
<td><font color=#6F9915>-3.360</font></td>
<td><font color=#6F9915>87.72%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>37.10</font></td>
<td><font color=#6F9915>36.90</font></td>
<td><font color=#6F9915>-0.197</font></td>
<td><font color=#6F9915>99.47%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>41.34</font></td>
<td><font color=#6F9915>39.08</font></td>
<td><font color=#6F9915>-2.260</font></td>
<td><font color=#6F9915>94.53%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>69.85</font></td>
<td><font color=#F92663>69.94</font></td>
<td><font color=#F92663>0.092</font></td>
<td><font color=#F92663>100.13%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.48</font></td>
<td><font color=#F92663>7.58</font></td>
<td><font color=#F92663>0.099</font></td>
<td><font color=#F92663>101.33%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>87.34</font></td>
<td><font color=#6F9915>86.14</font></td>
<td><font color=#6F9915>-1.203</font></td>
<td><font color=#6F9915>98.62%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>85.05</font></td>
<td><font color=#F92663>85.13</font></td>
<td><font color=#F92663>0.073</font></td>
<td><font color=#F92663>100.09%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>124.31</font></td>
<td><font color=#6F9915>122.27</font></td>
<td><font color=#6F9915>-2.041</font></td>
<td><font color=#6F9915>98.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.36</font></td>
<td><font color=#6F9915>43.15</font></td>
<td><font color=#6F9915>-2.206</font></td>
<td><font color=#6F9915>95.14%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.43</font></td>
<td><font color=#F92663>21.01</font></td>
<td><font color=#F92663>0.583</font></td>
<td><font color=#F92663>102.85%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>28.57</font></td>
<td><font color=#6F9915>27.87</font></td>
<td><font color=#6F9915>-0.705</font></td>
<td><font color=#6F9915>97.53%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>54.36</font></td>
<td><font color=#F92663>55.25</font></td>
<td><font color=#F92663>0.890</font></td>
<td><font color=#F92663>101.64%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>18.41</font></td>
<td><font color=#F92663>20.45</font></td>
<td><font color=#F92663>2.033</font></td>
<td><font color=#F92663>111.04%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>30.50</font></td>
<td><font color=#6F9915>28.88</font></td>
<td><font color=#6F9915>-1.621</font></td>
<td><font color=#6F9915>94.69%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>13.97</font></td>
<td><font color=#F92663>14.54</font></td>
<td><font color=#F92663>0.578</font></td>
<td><font color=#F92663>104.14%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>102.31</font></td>
<td><font color=#F92663>106.73</font></td>
<td><font color=#F92663>4.422</font></td>
<td><font color=#F92663>104.32%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>147.87</font></td>
<td><font color=#6F9915>147.26</font></td>
<td><font color=#6F9915>-0.618</font></td>
<td><font color=#6F9915>99.58%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.55</font></td>
<td><font color=#F92663>13.90</font></td>
<td><font color=#F92663>0.346</font></td>
<td><font color=#F92663>102.55%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>28.75</font></td>
<td><font color=#F92663>28.89</font></td>
<td><font color=#F92663>0.136</font></td>
<td><font color=#F92663>100.47%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>288.81</font></td>
<td><font color=#F92663>295.12</font></td>
<td><font color=#F92663>6.308</font></td>
<td><font color=#F92663>102.18%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>15.13</font></td>
<td><font color=#F92663>17.71</font></td>
<td><font color=#F92663>2.574</font></td>
<td><font color=#F92663>117.01%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1323.95</font></td>
<td><font color=#F92663>1328.16</font></td>
<td><font color=#F92663>4.205</font></td>
<td><font color=#F92663>100.32%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp commented on code in PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#discussion_r1577498529
##########
gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##########
@@ -419,7 +419,7 @@ trait SparkPlanExecApi {
substraitExprName: String,
child: ExpressionTransformer,
original: Round): ExpressionTransformer = {
- GenericExpressionTransformer(substraitExprName, Seq(child), original)
+ DecimalRoundTransformer(substraitExprName, child, original)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074384307
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2075393783
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5513_time.csv</font></td>
<td><font color=#000000>log/native_master_04_23_2024_fd2519a2b_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>36.65</font></td>
<td><font color=#6F9915>36.36</font></td>
<td><font color=#6F9915>-0.298</font></td>
<td><font color=#6F9915>99.19%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>26.15</font></td>
<td><font color=#6F9915>24.01</font></td>
<td><font color=#6F9915>-2.137</font></td>
<td><font color=#6F9915>91.83%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>37.48</font></td>
<td><font color=#6F9915>36.90</font></td>
<td><font color=#6F9915>-0.579</font></td>
<td><font color=#6F9915>98.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>40.28</font></td>
<td><font color=#6F9915>39.08</font></td>
<td><font color=#6F9915>-1.200</font></td>
<td><font color=#6F9915>97.02%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>72.28</font></td>
<td><font color=#6F9915>69.94</font></td>
<td><font color=#6F9915>-2.336</font></td>
<td><font color=#6F9915>96.77%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>7.45</font></td>
<td><font color=#F92663>7.58</font></td>
<td><font color=#F92663>0.128</font></td>
<td><font color=#F92663>101.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>85.80</font></td>
<td><font color=#F92663>86.14</font></td>
<td><font color=#F92663>0.337</font></td>
<td><font color=#F92663>100.39%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>86.89</font></td>
<td><font color=#6F9915>85.13</font></td>
<td><font color=#6F9915>-1.762</font></td>
<td><font color=#6F9915>97.97%</font></td>
</tr>
<tr>
<td><font color=#F92663>q9</font></td>
<td><font color=#F92663>118.53</font></td>
<td><font color=#F92663>122.27</font></td>
<td><font color=#F92663>3.736</font></td>
<td><font color=#F92663>103.15%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.05</font></td>
<td><font color=#6F9915>43.15</font></td>
<td><font color=#6F9915>-1.891</font></td>
<td><font color=#6F9915>95.80%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.94</font></td>
<td><font color=#F92663>21.01</font></td>
<td><font color=#F92663>0.072</font></td>
<td><font color=#F92663>100.34%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>27.47</font></td>
<td><font color=#F92663>27.87</font></td>
<td><font color=#F92663>0.397</font></td>
<td><font color=#F92663>101.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>56.63</font></td>
<td><font color=#6F9915>55.25</font></td>
<td><font color=#6F9915>-1.381</font></td>
<td><font color=#6F9915>97.56%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>17.74</font></td>
<td><font color=#F92663>20.45</font></td>
<td><font color=#F92663>2.703</font></td>
<td><font color=#F92663>115.23%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>29.94</font></td>
<td><font color=#6F9915>28.88</font></td>
<td><font color=#6F9915>-1.067</font></td>
<td><font color=#6F9915>96.44%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>14.00</font></td>
<td><font color=#F92663>14.54</font></td>
<td><font color=#F92663>0.544</font></td>
<td><font color=#F92663>103.88%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>106.11</font></td>
<td><font color=#F92663>106.73</font></td>
<td><font color=#F92663>0.627</font></td>
<td><font color=#F92663>100.59%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>147.22</font></td>
<td><font color=#F92663>147.26</font></td>
<td><font color=#F92663>0.039</font></td>
<td><font color=#F92663>100.03%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.79</font></td>
<td><font color=#F92663>13.90</font></td>
<td><font color=#F92663>0.107</font></td>
<td><font color=#F92663>100.78%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>29.48</font></td>
<td><font color=#6F9915>28.89</font></td>
<td><font color=#6F9915>-0.590</font></td>
<td><font color=#6F9915>98.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>285.60</font></td>
<td><font color=#F92663>295.12</font></td>
<td><font color=#F92663>9.520</font></td>
<td><font color=#F92663>103.33%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.53</font></td>
<td><font color=#F92663>17.71</font></td>
<td><font color=#F92663>3.178</font></td>
<td><font color=#F92663>121.88%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1320.01</font></td>
<td><font color=#F92663>1328.16</font></td>
<td><font color=#F92663>8.147</font></td>
<td><font color=#F92663>100.62%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "rui-mo (via GitHub)" <gi...@apache.org>.
rui-mo commented on code in PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#discussion_r1577269324
##########
gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##########
@@ -419,7 +419,7 @@ trait SparkPlanExecApi {
substraitExprName: String,
child: ExpressionTransformer,
original: Round): ExpressionTransformer = {
- GenericExpressionTransformer(substraitExprName, Seq(child), original)
+ DecimalRoundTransformer(substraitExprName, child, original)
Review Comment:
It seems we can remove the API `genDecimalRoundTransformer` directly as it has the same implementation as Velox backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2073884216
https://github.com/apache/incubator-gluten/issues/5512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074421385
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "loneylee (via GitHub)" <gi...@apache.org>.
loneylee commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074432861
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp merged PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074673446
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2073884387
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp commented on PR #5513:
URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2073884314
@loneylee please help to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org