[GitHub] [myfaces] volosied commented on a diff in pull request #371: MYFACES-4493: Allow Jakarta and JCP namespaces for FacesComponent

[GitBox <gi...@apache.org>]

volosied commented on code in PR #371:
URL: https://github.com/apache/myfaces/pull/371#discussion_r1010565345


##########
impl/src/main/java/org/apache/myfaces/config/element/FacesConfig.java:
##########
@@ -93,9 +93,9 @@ public List<String> getProtectedViewsUrlPatternList()
      * @since 2.2.0
      * @return 
      */
-    public Map<String, ComponentTagDeclaration> getComponentTagDeclarations()
+    public List<ComponentTagDeclaration> getComponentTagDeclarations()
     {
-        return Collections.emptyMap();
+        return Collections.emptyList();

Review Comment:
   If this is accepted, how should I update the description?  Keep it as `@since 2.2.0` or update to 4.0.0?  Maybe just mention the new return type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org