You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gf53520 <gi...@git.apache.org> on 2017/03/01 16:48:02 UTC

[GitHub] spark pull request #17124: Delete needless tmp file after restart structured...

GitHub user gf53520 opened a pull request:

    https://github.com/apache/spark/pull/17124

    Delete needless tmp file after restart structured streaming job

    ## What changes were proposed in this pull request?
    
    [SPARK-19779](https://issues.apache.org/jira/browse/SPARK-19779)
    
    The PR (https://github.com/apache/spark/pull/17012) can to fix restart a Structured Streaming application using hdfs as fileSystem, but also exist a problem that a tmp file of delta file is still reserved in hdfs. And Structured Streaming don't delete the tmp file generated when restart streaming job in future.
    
    ## How was this patch tested?
     unit tests
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gf53520/spark SPARK-19779

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17124
    
----
commit 5600776066e083655fe328915b56936775273e15
Author: guifeng <gu...@gmail.com>
Date:   2017-03-01T16:30:49Z

    Delete needless tmp file after restart structured streaming job

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73803/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103864707
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is the only choice. It's still
           // semantically correct because Structured Streaming requires rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch after restart
    --- End diff --
    
    This comment is not 100% correct, this may also happen in a speculation task.
    
    This PR is just a follow up to delete the temp file that #17012 forgot to do it. IMO, not need to add a comment for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103865389
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala ---
    @@ -295,6 +295,28 @@ class StateStoreSuite extends SparkFunSuite with BeforeAndAfter with PrivateMeth
         provider.getStore(0).commit()
       }
     
    +  test("SPARK-19779: A tmp file of delta file should not be reserved on HDFS " +
    --- End diff --
    
    Instead of adding a new test, I prefer to just add several lines to the above `SPARK-19677: Committing a delta file atop an existing one should not fail on HDFS`. E.g.
    
    ```
      test("SPARK-19677: Committing a delta file atop an existing one should not fail on HDFS") {
        val conf = new Configuration()
        conf.set("fs.fake.impl", classOf[RenameLikeHDFSFileSystem].getName)
        conf.set("fs.default.name", "fake:///")
    
        val provider = newStoreProvider(hadoopConf = conf)
        provider.getStore(0).commit()
        provider.getStore(0).commit()
    
        // Verify we don't leak temp files
        val tempFiles = FileUtils.listFiles(new File(provider.id.checkpointLocation), null, true)
          .asScala.filter(_.getName.contains("temp-"))
        assert(tempFiles.isEmpty)
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #3589 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3589/testReport)** for PR 17124 at commit [`5600776`](https://github.com/apache/spark/commit/5600776066e083655fe328915b56936775273e15).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    ok to test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103732674
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is the only choice. It's still
           // semantically correct because Structured Streaming requires rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch after restart
    +      // streaming job is still reserved on HDFS. (SPARK-19779)
           // scalastyle:on
    -      if (!fs.exists(finalDeltaFile) && !fs.rename(tempDeltaFile, finalDeltaFile)) {
    +      if (fs.exists(finalDeltaFile)) {
    +        fs.delete(tempDeltaFile, true)
    +      } else if (!fs.rename(tempDeltaFile, finalDeltaFile)) {
    --- End diff --
    
    If the file exists, it is deleted, but no new file is renamed to it -- is that right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #73786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73786/testReport)** for PR 17124 at commit [`db3f4db`](https://github.com/apache/spark/commit/db3f4dbc39e5688778ab9c72901ebf20ca4bf727).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #73803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73803/testReport)** for PR 17124 at commit [`c5895e2`](https://github.com/apache/spark/commit/c5895e26d26edeafe83b335a6f3cf1a9c4efcbf4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #73786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73786/testReport)** for PR 17124 at commit [`db3f4db`](https://github.com/apache/spark/commit/db3f4dbc39e5688778ab9c72901ebf20ca4bf727).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/17124


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by gf53520 <gi...@git.apache.org>.
Github user gf53520 commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103737250
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is the only choice. It's still
           // semantically correct because Structured Streaming requires rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch after restart
    +      // streaming job is still reserved on HDFS. (SPARK-19779)
           // scalastyle:on
    -      if (!fs.exists(finalDeltaFile) && !fs.rename(tempDeltaFile, finalDeltaFile)) {
    +      if (fs.exists(finalDeltaFile)) {
    +        fs.delete(tempDeltaFile, true)
    +      } else if (!fs.rename(tempDeltaFile, finalDeltaFile)) {
    --- End diff --
    
    I guess my point is, after this change, the file may not exist after this executes. Before, it always existed after this block. I wasn't sure that was the intended behavior change because the purpose seems to be to delete the temp file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by gf53520 <gi...@git.apache.org>.
Github user gf53520 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103734243
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is the only choice. It's still
           // semantically correct because Structured Streaming requires rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch after restart
    +      // streaming job is still reserved on HDFS. (SPARK-19779)
           // scalastyle:on
    -      if (!fs.exists(finalDeltaFile) && !fs.rename(tempDeltaFile, finalDeltaFile)) {
    +      if (fs.exists(finalDeltaFile)) {
    +        fs.delete(tempDeltaFile, true)
    +      } else if (!fs.rename(tempDeltaFile, finalDeltaFile)) {
    --- End diff --
    
    when restart streaming job , the`finalDeltaFile`  is same to a `finalDeltaFile` generated last batch of streaming job before restart. So here don't need rename to create an same file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by gf53520 <gi...@git.apache.org>.
Github user gf53520 commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    @zsxwing  I have rewritten the test case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17124: [SPARK-19779][SS]Delete needless tmp file after r...

Posted by gf53520 <gi...@git.apache.org>.
Github user gf53520 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17124#discussion_r103740176
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -282,8 +282,12 @@ private[state] class HDFSBackedStateStoreProvider(
           // target file will break speculation, skipping the rename step is the only choice. It's still
           // semantically correct because Structured Streaming requires rerunning a batch should
           // generate the same output. (SPARK-19677)
    +      // Also, a tmp file of delta file that generated by the first batch after restart
    +      // streaming job is still reserved on HDFS. (SPARK-19779)
           // scalastyle:on
    -      if (!fs.exists(finalDeltaFile) && !fs.rename(tempDeltaFile, finalDeltaFile)) {
    +      if (fs.exists(finalDeltaFile)) {
    +        fs.delete(tempDeltaFile, true)
    +      } else if (!fs.rename(tempDeltaFile, finalDeltaFile)) {
    --- End diff --
    
    Yes. This pr just want to delete the needless temp file, and the delta file need exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #73803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73803/testReport)** for PR 17124 at commit [`c5895e2`](https://github.com/apache/spark/commit/c5895e26d26edeafe83b335a6f3cf1a9c4efcbf4).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    LGTM. Merging to master, 2.1 and 2.0. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73786/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17124: [SPARK-19779][SS]Delete needless tmp file after restart ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17124
  
    **[Test build #3589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3589/testReport)** for PR 17124 at commit [`5600776`](https://github.com/apache/spark/commit/5600776066e083655fe328915b56936775273e15).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org