You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/08 07:26:24 UTC

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22467


Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................

[tests] fix MaintenanceManagerTest.TestRunningInstances

Changelist [1] introduced an extra assertion that started triggering
from time to time [2].  In addition, since
MaintenanceManager::GetMaintenanceManagerStatusDump() doesn't
clear its output parameter, ASSERT_EVENTUALLY() would accumulate
information on running and completed operations when retrying [3].

This is a follow-up to [1] to address those issues.

[1] https://github.com/apache/kudu/commit/026516a70
[2] http://dist-test.cloudera.org:8080/diagnose?key=f8d3ec0a-e597-11ef-b2cd-42010af00016
[3] http://dist-test.cloudera.org:8080/diagnose?key=026e8330-e596-11ef-a3c0-42010af00016

Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 34 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/22467/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 19:05:20 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1050/


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 16:28:16 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1049/


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:45:45 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: Verified+1

unrelated test failures:
  * TSAN: warning due to OpDriver and Tablet lifecycle end-case
  * RELEASE: KUDU-3194


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 20:20:51 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1048/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:45:39 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1049/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 08:24:59 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................

[tests] fix MaintenanceManagerTest.TestRunningInstances

Changelist [1] introduced an extra assertion that started triggering
from time to time [2].  In addition, since
MaintenanceManager::GetMaintenanceManagerStatusDump() doesn't
clear its output parameter, ASSERT_EVENTUALLY() would accumulate
information on running and completed operations when retrying [3].

This is a follow-up to [1] to address those issues.

[1] https://github.com/apache/kudu/commit/026516a70
[2] http://dist-test.cloudera.org:8080/diagnose?key=f8d3ec0a-e597-11ef-b2cd-42010af00016
[3] http://dist-test.cloudera.org:8080/diagnose?key=026e8330-e596-11ef-a3c0-42010af00016

Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Reviewed-on: http://gerrit.cloudera.org:8080/22467
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 24 insertions(+), 5 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1048/


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 08 Feb 2025 07:26:34 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22467

to look at the new patch set (#2).

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................

[tests] fix MaintenanceManagerTest.TestRunningInstances

Changelist [1] introduced an extra assertion that started triggering
from time to time [2].  In addition, since
MaintenanceManager::GetMaintenanceManagerStatusDump() doesn't
clear its output parameter, ASSERT_EVENTUALLY() would accumulate
information on running and completed operations when retrying [3].

This is a follow-up to [1] to address those issues.

[1] https://github.com/apache/kudu/commit/026516a70
[2] http://dist-test.cloudera.org:8080/diagnose?key=f8d3ec0a-e597-11ef-b2cd-42010af00016
[3] http://dist-test.cloudera.org:8080/diagnose?key=026e8330-e596-11ef-a3c0-42010af00016

Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 24 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/22467/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [tests] fix MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22467 )

Change subject: [tests] fix MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1050/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd0ebc96582109b91f1a8e85d66cca7131750ae
Gerrit-Change-Number: 22467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Sat, 08 Feb 2025 18:21:55 +0000
Gerrit-HasComments: No