Re: [PR] feat(extensions): admin configuration UI for extensions [superset]

["EnxDev (via GitHub)" <gi...@apache.org>]

EnxDev commented on code in PR #40442:
URL: https://github.com/apache/superset/pull/40442#discussion_r3341257286


##########
superset-frontend/src/extensions/ExtensionsList.tsx:
##########
@@ -17,20 +17,37 @@
  * under the License.
  */
 import { t } from '@apache-superset/core/translation';
-import { FunctionComponent, useMemo } from 'react';
+import { css } from '@apache-superset/core/theme';
+import {
+  FunctionComponent,
+  useCallback,
+  useEffect,
+  useMemo,
+  useRef,
+  useState,
+} from 'react';
+import { SupersetClient } from '@superset-ui/core';
+import { Select, Switch } from '@superset-ui/core/components';
 import { useListViewResource } from 'src/views/CRUD/hooks';
 import { ListView } from 'src/components';
 import SubMenu, { SubMenuProps } from 'src/features/home/SubMenu';
 import withToasts from 'src/components/MessageToasts/withToasts';
+import { CHATBOT_LOCATION } from 'src/views/contributions';
+import { getRegisteredViewIds, subscribeToLocation } from 'src/core/views';

Review Comment:
   subscribeToLocation was replaced by the registry-wide subscribeToRegistry/getRegistryVersion in the eager-loading PR below this one. This branch hadn't picked up that rename yet, so ExtensionsList was still on the old API. Merged the updated base in and migrated ExtensionsList to useSyncExternalStore(subscribeToRegistry, getRegistryVersion). Consistent now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org