You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/18 13:10:54 UTC
[GitHub] [cloudstack] kioie opened a new pull request #3979: [WIP] Limit API
from trying to start a VM that is already running
kioie opened a new pull request #3979: [WIP] Limit API from trying to start a VM that is already running
URL: https://github.com/apache/cloudstack/pull/3979
## Description
<!--- Describe your changes in detail -->
Enhancement for issue #2736
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
<img width="796" alt="Screenshot 2020-03-18 at 16 06 54" src="https://user-images.githubusercontent.com/20902920/76963857-c30e5880-6932-11ea-9199-a5f6dddd5d33.png">
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. Start a VM
2. With cloudmonkey, start the same VM
3. Observe the result
Response should fail the job and say VM is already in running state.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3979: Limit API from
trying to start a VM that is already running
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3979: Limit API from trying to start a VM that is already running
URL: https://github.com/apache/cloudstack/pull/3979#issuecomment-600708578
I don't mind this code but it seems to me that there is no state transition from started to started and hence this should already fail. If it doesn't there is a bug in the statemachine implementation or - design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services