You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/06/02 21:11:46 UTC
[PR] Add labels to translations PRs [airflow]
jscheffl opened a new pull request, #51330:
URL: https://github.com/apache/airflow/pull/51330
In order to better maintain complexity of PRs about translations I propose we add a couple of labels to better find all issues/PRs related to a certain language and translation.
Would this make sense? Or should we use other mechanims?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2122513817
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
Per language seems to make sense to me as the reviewers of one language might not be able to review another language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2122243547
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
I have no strong opinion - but considered it might be good/valueable as translation contributorto see all changes in a language translation by filtering. For example for review. (As if not being codeowner then you can filter a query by the language of interest) Or if we want to report of PRs for a certain language (has there been recent activity on NL translation?) - otherwise might be complex to filter?
But you have more expertise in labels :-D
Maybe also useful to mark translation errors for respective languages/maintainers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2122193503
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
Do we need label per language? Seems a bit excessive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2123443214
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
> That is what code owners are for
Yes, but for translations we probably have people who are not listed in CODEOWNERS so labels might be the chance to find PRs seeking for contribution/review.
I can take care to maintain (or even contribute a pre-commit check to automate) if you want to push it over the fence... I can take over if you like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2133852652
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
Okay, I extended the checker in pre-commit for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #51330:
URL: https://github.com/apache/airflow/pull/51330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2122558363
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
Translations is under havey development but I expect it to be reduced soon. At the end translation is 2 files which will remain stable with little to no changes (unlike provider packages).
Having a label per translation mean that someone needs to maintain it, creating the label, updating the labeling bot etc...
If we want label per language we need someone to volunteer to own it, including marking issues and writing the triage policy for it. This cant be left to the owner of a specific language.
To me it seems like a lot of work for little value but if someone wants to have it and willing to set it up feel free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2122546819
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
That is what code owners are for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add labels to translations PRs [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #51330:
URL: https://github.com/apache/airflow/pull/51330#discussion_r2123922333
##########
.github/boring-cyborg.yml:
##########
@@ -344,6 +344,27 @@ labelPRBasedOnFilePath:
- airflow-core/docs/ui.rst
- airflow-core/src/airflow/ui/**/*
+ area:translations:
+ - airflow-core/src/airflow/ui/src/i18n/**/*
+
+ translation:default:
+ - airflow-core/src/airflow/ui/src/i18n/locales/en/*
+
+ translation:de:
Review Comment:
In the long term, if we maintain translations as sort of "mini Python packages" - I think that it makes sense to treat them like providers, so each will have its own label. Issues/PRs will be easier to filter for both analytical and practical purposes, not only by code owners.
I agree though that it needs to be maintained or automated (thanks Jens!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org