[GitHub] [pinot] snleee commented on a diff in pull request #9954: report minion task metadata last update time as metric

[GitBox <gi...@apache.org>]

snleee commented on code in PR #9954:
URL: https://github.com/apache/pinot/pull/9954#discussion_r1044638238


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -52,6 +52,7 @@ public enum ControllerGauge implements AbstractMetrics.Gauge {
   OFFLINE_TABLE_COUNT("TableCount", true),
   DISABLED_TABLE_COUNT("TableCount", true),
   PERIODIC_TASK_NUM_TABLES_PROCESSED("PeriodicTaskNumTablesProcessed", true),
+  MINION_TASK_METADATA_LAST_UPDATE_TIME_MS("MinionTaskMetadataLastUpdateTimeMs", true),

Review Comment:
   Can we think of normalizing the metrics? Reporting the raw timestamp value will require ppl to re-interpret that to the human readable format so it's going to be a bit hard to use.
   
   For example, the same information can be defined as `the time since last update in hours (or days)`. This will show as low number in regular time and it will increase if there's no update at all for a long time. Once we make some progress, it will go down to 0 again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org