You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/04/01 19:10:32 UTC
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18376
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
In some test runs test_table_load_time_for_many_files failed because
the time limit (3 seconds) was too short. In the failed tests it was
around 4 seconds to execute the DESCRIBE statement.
This patch increases the time limit to 10 seconds when HDFS is used.
This should be long enough to fix the flakiness, but short enough
to catch pathologically long table loads (the one that was fixed by
IMPALA-11214).
Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
---
M tests/query_test/test_iceberg.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18376/1
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10382/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 01 Apr 2022 19:29:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 01 Apr 2022 23:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8006/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 01 Apr 2022 19:19:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 01 Apr 2022 19:19:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 01 Apr 2022 19:16:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-111218: TestIcebergTable.test table load time for many files flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18376 )
Change subject: IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
......................................................................
IMPALA-111218: TestIcebergTable.test_table_load_time_for_many_files flaky
In some test runs test_table_load_time_for_many_files failed because
the time limit (3 seconds) was too short. In the failed tests it was
around 4 seconds to execute the DESCRIBE statement.
This patch increases the time limit to 10 seconds when HDFS is used.
This should be long enough to fix the flakiness, but short enough
to catch pathologically long table loads (the one that was fixed by
IMPALA-11214).
Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Reviewed-on: http://gerrit.cloudera.org:8080/18376
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_iceberg.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic48bb561e97c008c6f4e51fc9d9ec8b3f7cdaf9e
Gerrit-Change-Number: 18376
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>