You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2017/12/11 18:48:30 UTC

Review Request 64503: [ATLAS-2308]: Remove 'titan1' graph provider from atlas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64503/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2308
    https://issues.apache.org/jira/browse/ATLAS-2308


Repository: atlas


Description
-------

We have 3 graph databases in atlas:
1. titan0 (Titan 0.5.4)
2. titan1 (Titan 1.0.0)
3. janus (JanusGraph 0.2.0)

The default graph-provider is JanusGraph currently. I propose we remove 'titan1' graph provider from Atlas for reasons below:
1. 'titan1' has not been tested thoroughly and have higher chances of potential issues.
2. We have moved on to use JanusGraph in Atlas which is an improved graph database forked from Titan 1 with community support and active development going on. 
3. TitanDB is retired, the new project JanusGraph which is now part of the Linux foundation has more interest and backing.

We will continue to support 'titan0' as Titan 0.5.4 has been tested and have wider audience within the community and also to support backward compatibility.
Attach one or more files to this issue


Diffs
-----

  graphdb/pom.xml 426238cf 
  graphdb/readme.txt 2ad78456 
  graphdb/titan1/pom.xml b9483bad 
  graphdb/titan1/readme.txt 4fcddbaf 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java 7928a846 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java bcc009bb 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1EdgeLabel.java fdcc33dc 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java b1cd4583 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java d94289dc 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java dfb53545 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java 5ec11803 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java a5d3815b 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java c7e4150f 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java 6b62f27e 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java 1670e929 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java a761a744 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java a4776a9f 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java df67a836 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java 2bab2877 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java 49bbdb43 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java 26abe2e4 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java 733964de 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java dd0176bf 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java c1a096db 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java dfda9f6e 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java eb99faee 
  graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java c3e2d1c5 
  graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory 24c8a755 
  graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java 06e27851 
  graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java 45fbbea6 
  graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java ab2c8c94 
  graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java 53148fa6 
  graphdb/titan1/src/test/resources/atlas-application.properties af63dd82 
  pom.xml 4ee2d9ec 


Diff: https://reviews.apache.org/r/64503/diff/1/


Testing
-------

mvn clean package succeeded.


Thanks,

Sarath Subramanian


Re: Review Request 64503: [ATLAS-2308]: Remove 'titan1' graph provider from atlas

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64503/#review193475
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 11, 2017, 6:48 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64503/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2017, 6:48 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2308
>     https://issues.apache.org/jira/browse/ATLAS-2308
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> We have 3 graph databases in atlas:
> 1. titan0 (Titan 0.5.4)
> 2. titan1 (Titan 1.0.0)
> 3. janus (JanusGraph 0.2.0)
> 
> The default graph-provider is JanusGraph currently. I propose we remove 'titan1' graph provider from Atlas for reasons below:
> 1. 'titan1' has not been tested thoroughly and have higher chances of potential issues.
> 2. We have moved on to use JanusGraph in Atlas which is an improved graph database forked from Titan 1 with community support and active development going on. 
> 3. TitanDB is retired, the new project JanusGraph which is now part of the Linux foundation has more interest and backing.
> 
> We will continue to support 'titan0' as Titan 0.5.4 has been tested and have wider audience within the community and also to support backward compatibility.
> Attach one or more files to this issue
> 
> 
> Diffs
> -----
> 
>   graphdb/pom.xml 426238cf 
>   graphdb/readme.txt 2ad78456 
>   graphdb/titan1/pom.xml b9483bad 
>   graphdb/titan1/readme.txt 4fcddbaf 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/GraphDbObjectFactory.java 7928a846 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Edge.java bcc009bb 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1EdgeLabel.java fdcc33dc 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Element.java b1cd4583 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java d94289dc 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java dfb53545 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java 5ec11803 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java a5d3815b 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java c7e4150f 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1PropertyKey.java 6b62f27e 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java 1670e929 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java a761a744 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/TitanObjectFactory.java a4776a9f 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java df67a836 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONMode.java 2bab2877 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONTokens.java 49bbdb43 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java 26abe2e4 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java 733964de 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1GraphQuery.java dd0176bf 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigDecimalSerializer.java c1a096db 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/BigIntegerSerializer.java dfda9f6e 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java eb99faee 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/TypeCategorySerializer.java c3e2d1c5 
>   graphdb/titan1/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory 24c8a755 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java 06e27851 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java 45fbbea6 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java ab2c8c94 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/TitanGraphProviderTest.java 53148fa6 
>   graphdb/titan1/src/test/resources/atlas-application.properties af63dd82 
>   pom.xml 4ee2d9ec 
> 
> 
> Diff: https://reviews.apache.org/r/64503/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package succeeded.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>