You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2021/02/02 19:25:35 UTC

[lucene-solr] branch reference_impl updated: @1306 Remove this sync.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl by this push:
     new 18c0208  @1306 Remove this sync.
18c0208 is described below

commit 18c020881e301d269c235806f532275582d5023e
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Feb 2 13:24:37 2021 -0600

    @1306 Remove this sync.
---
 solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java b/solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java
index 3f9d586..dafdc78 100644
--- a/solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java
+++ b/solr/core/src/java/org/apache/solr/core/CorePropertiesLocator.java
@@ -78,10 +78,8 @@ public class CorePropertiesLocator implements CoresLocator {
       writePropertiesFile(cd, propFile);
     }
   }
-
-  // we have to be careful about writing and reading the same file without a lock
-  // this sync is a little heavy, but given it's a tiny file we are writing, should do for now
-  private synchronized void writePropertiesFile(CoreDescriptor cd, Path propfile)  {
+  
+  private void writePropertiesFile(CoreDescriptor cd, Path propfile)  {
     Properties p = buildCoreProperties(cd);
     try {
       FileUtils.createDirectories(propfile.getParent()); // Handling for symlinks.