You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Ismael Juma (Jira)" <ji...@apache.org> on 2020/03/05 16:45:00 UTC
[jira] [Commented] (KAFKA-9665) Scala compiler not producing unused
warnings
[ https://issues.apache.org/jira/browse/KAFKA-9665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052323#comment-17052323 ]
Ismael Juma commented on KAFKA-9665:
------------------------------------
Catching unused is very useful, I agree. That said, I think we should do this. The Y flags are experimental. I think we should switch to Scala 2.13 instead, but I was waiting for 2.13.2 to be out since that will provide additional motivation for the change.
> Scala compiler not producing unused warnings
> --------------------------------------------
>
> Key: KAFKA-9665
> URL: https://issues.apache.org/jira/browse/KAFKA-9665
> Project: Kafka
> Issue Type: Bug
> Components: build
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Minor
>
> While reviewing KAFKA-9661, I wondered about the compiler giving us a warning for unused locals. I ran the build locally and didn't see any warnings. Turns out Scala 2.12 doesn't support the compiler flag {{-Xlint:unused}}. Since we build with 2.12 by default, we can easily miss these warnings.
> We should instead use {{-Ywarn-unused:locals}} and others which work for scalac 2.12 and 2.13.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)