[Bug 3837] New: Received parser: over-broad RE getting rDNS and HELO mixed up

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=3837

           Summary: Received parser: over-broad RE getting rDNS and HELO
                    mixed up
           Product: Spamassassin
           Version: 3.0.0
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: jm@jmason.org


My "helo as 0" taiwanese spammer is exercising the Received parser quite a lot!
 here's another bug it's thrown up.

it seems that if a relay adds a header that isn't covered by a specific entry,
it gets caught early by another RE, instead of making it through to the "general
case" fallback REs.  unfortunately this other RE is inaccurate; it incorrectly
considers headers of this form:

   Received: from helostring ([ip.ad.dr.ess]) by blah blah...

to mean

   ip=ip.ad.dr.ess helo= rdns=helostring

instead of

   ip=ip.ad.dr.ess helo=helostring rdns=

this is a bug.  here's the fix.  I've also found two of our test cases were
incorrectly treating this as correct (!), so that's fixed too.

I've also found an inefficient RE, which relied on a specific string at the end
of the RE after a .*.  this is bad.  split into two independent REs, which is a
lot more efficient.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.