You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Hao Hao via Review Board <no...@reviews.apache.org> on 2018/12/10 01:01:17 UTC
Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/
-----------------------------------------------------------
Review request for sentry, Na Li and Sergio Pena.
Repository: sentry
Description
-------
SENTRY-2471: Table rename should sync Sentry privilege even without location information
Diffs
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
Diff: https://reviews.apache.org/r/69536/diff/1/
Testing
-------
existing unit tests
Thanks,
Hao Hao
Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/#review211170
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java
Lines 418 (patched)
<https://reviews.apache.org/r/69536/#comment296098>
Can you make comment more explicit on path info is not complete?
- Na Li
On Dec. 10, 2018, 2:21 a.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69536/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 2:21 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2471: Table rename should sync Sentry privilege even without location information
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
>
>
> Diff: https://reviews.apache.org/r/69536/diff/2/
>
>
> Testing
> -------
>
> existing unit tests
>
>
> Thanks,
>
> Hao Hao
>
>
Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/#review212797
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Feb. 7, 2019, 1:04 a.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69536/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2019, 1:04 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2471: Table rename should sync Sentry privilege even without location information
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java f227bb45835b98e6fef14399a239d7f9975d56d1
>
>
> Diff: https://reviews.apache.org/r/69536/diff/3/
>
>
> Testing
> -------
>
> added new unit tests
>
>
> Thanks,
>
> Hao Hao
>
>
Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
Posted by Hao Hao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/
-----------------------------------------------------------
(Updated Feb. 7, 2019, 1:04 a.m.)
Review request for sentry, Na Li and Sergio Pena.
Repository: sentry
Description
-------
SENTRY-2471: Table rename should sync Sentry privilege even without location information
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java f227bb45835b98e6fef14399a239d7f9975d56d1
Diff: https://reviews.apache.org/r/69536/diff/3/
Changes: https://reviews.apache.org/r/69536/diff/2-3/
Testing (updated)
-------
added new unit tests
Thanks,
Hao Hao
Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/#review211171
-----------------------------------------------------------
can you add test case to cover the issue you want to fix? There is no path info, but if the table name is changed, the privilege is moved to table of new name?
- Na Li
On Dec. 10, 2018, 2:21 a.m., Hao Hao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69536/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 2:21 a.m.)
>
>
> Review request for sentry, Na Li and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-2471: Table rename should sync Sentry privilege even without location information
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
>
>
> Diff: https://reviews.apache.org/r/69536/diff/2/
>
>
> Testing
> -------
>
> existing unit tests
>
>
> Thanks,
>
> Hao Hao
>
>
Re: Review Request 69536: SENTRY-2471: Table rename should sync Sentry
privilege even without location information
Posted by Hao Hao via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69536/
-----------------------------------------------------------
(Updated Dec. 10, 2018, 2:21 a.m.)
Review request for sentry, Na Li and Sergio Pena.
Repository: sentry
Description
-------
SENTRY-2471: Table rename should sync Sentry privilege even without location information
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff
Diff: https://reviews.apache.org/r/69536/diff/2/
Changes: https://reviews.apache.org/r/69536/diff/1-2/
Testing
-------
existing unit tests
Thanks,
Hao Hao