You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2023/02/27 22:39:26 UTC

[superset] 06/07: fix(ssh-tunnel): add password to `from_private_key` function (#23175)

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch 2.1-test
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 54ca85fbc632bf6fa0b69a77fb78d332253dd870
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Fri Feb 24 16:05:37 2023 -0800

    fix(ssh-tunnel): add password to `from_private_key` function (#23175)
    
    (cherry picked from commit cb9bff72d69bc1d3e08a3ecaa4f399961a2f566a)
---
 superset/extensions/ssh.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset/extensions/ssh.py b/superset/extensions/ssh.py
index 885732d6be..8fb235618c 100644
--- a/superset/extensions/ssh.py
+++ b/superset/extensions/ssh.py
@@ -61,9 +61,10 @@ class SSHManager:
             params["ssh_password"] = ssh_tunnel.password
         elif ssh_tunnel.private_key:
             private_key_file = StringIO(ssh_tunnel.private_key)
-            private_key = RSAKey.from_private_key(private_key_file)
+            private_key = RSAKey.from_private_key(
+                private_key_file, ssh_tunnel.private_key_password
+            )
             params["ssh_pkey"] = private_key
-            params["ssh_private_key_password"] = ssh_tunnel.private_key_password
 
         return open_tunnel(**params)