You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by nareshpr <gi...@git.apache.org> on 2016/08/29 10:25:43 UTC

[GitHub] incubator-carbondata pull request #105: [CARBONDATA-189] Drop database casca...

GitHub user nareshpr opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/105

    [CARBONDATA-189] Drop database cascade should be restricted

    Reason: Carbondata will not support "Drop database dbname cascade"
    When user provides this command, carbon will validate and give below error message "Unsupported cascade operation in drop database command"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nareshpr/incubator-carbondata restrictdropdbcascade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit 295694793a6a3f0616b6ac18527bef86c6644ee5
Author: nareshpr <pr...@gmail.com>
Date:   2016-08-29T09:55:40Z

    drop database cascade should be restricted

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #105: [CARBONDATA-189] Drop database casca...

Posted by sujith71955 <gi...@git.apache.org>.
Github user sujith71955 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/105#discussion_r76657713
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1342,4 +1345,9 @@ class CarbonSqlParser()
           }
         }
     
    +  protected lazy val dropDatabaseCascade: Parser[LogicalPlan] =
    +    DROP ~> (DATABASE|SCHEMA) ~> opt(IF ~> EXISTS) ~> ident ~> CASCADE <~ opt(";") ^^ {
    +      case cascade => throw new MalformedCarbonCommandException(
    +          "Unsupported cascade operation in drop database command")
    --- End diff --
    
    since system supports both database and schema better to provide message including schema like database/schema command like "Unsupported cascade operation in drop database/schema command" , else better provide  "Unsupported cascade operation in drop command".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---