You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/02/06 16:20:19 UTC
[PR] [MINOR][DOCS] Show sort order of NaN relative to infinity [spark]
nchammas opened a new pull request, #45047:
URL: https://github.com/apache/spark/pull/45047
### What changes were proposed in this pull request?
Tweak the examples in our documentation on NaN semantics to demonstrate how NaN sorts relative to infinity.
### Why are the changes needed?
The docs make an interesting point about how NaNs are sorted, but none of the examples that follow demonstrate this point.
https://github.com/apache/spark/blob/a6d5b6a2f89fb8aa8de835e7bf5c72b1bed32bf7/docs/sql-ref-datatypes.md#L294
### Does this PR introduce _any_ user-facing change?
Yes, it tweaks some documentation.
### How was this patch tested?
No testing.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Show sort order of NaN relative to infinity [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #45047:
URL: https://github.com/apache/spark/pull/45047#issuecomment-1934513407
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Show sort order of NaN relative to infinity [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #45047:
URL: https://github.com/apache/spark/pull/45047#issuecomment-1948964067
cc @cloud-fan and @peter-toth since we have been discussing NaNs over on #45036.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Show sort order of NaN relative to infinity [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #45047:
URL: https://github.com/apache/spark/pull/45047#issuecomment-1932909805
I don't think we have an actual unit test to check this sort behavior, so I added one as part of #45036 (which also verifies some other behavior we are discussing there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org