You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2022/04/19 09:51:24 UTC

[pulsar] 22/26: fix debug log authenticate role error (#14784)

This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit ac0a242a0e93fc8166f162fffcd74f6964e5b166
Author: Dezhi LIiu <33...@users.noreply.github.com>
AuthorDate: Wed Apr 13 08:58:14 2022 +0800

    fix debug log authenticate role error (#14784)
    
    (cherry picked from commit 97b7e77a9075159dd58a279d64f834e85472f437)
---
 .../main/java/org/apache/pulsar/broker/service/ServerCnx.java    | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
index 87eea84af8c..d8255f6015d 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
@@ -815,8 +815,13 @@ public class ServerCnx extends PulsarHandler implements TransportCnx {
             authenticationData = authState.getAuthDataSource();
 
             if (log.isDebugEnabled()) {
-                log.debug("[{}] Authenticate role : {}", remoteAddress,
-                    authState != null ? authState.getAuthRole() : null);
+                String role = "";
+                if (authState != null && authState.isComplete()) {
+                    role = authState.getAuthRole();
+                } else {
+                    role = "authentication incomplete or null";
+                }
+                log.debug("[{}] Authenticate role : {}", remoteAddress, role);
             }
 
             state = doAuthentication(clientData, clientProtocolVersion, clientVersion);