[GitHub] [samza] cameronlee314 commented on a change in pull request #1265: SAMZA-2441: Update ApplicationRunnerMain#ApplicationRunnerCommandLine not to load local file

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1265: SAMZA-2441: Update ApplicationRunnerMain#ApplicationRunnerCommandLine not to load local file
URL: https://github.com/apache/samza/pull/1265#discussion_r374937759
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java
 ##########
 @@ -43,9 +49,33 @@ public ApplicationRunnerOperation getOperation(OptionSet options) {
       String rawOp = options.valueOf(operationOpt);
       return ApplicationRunnerOperation.fromString(rawOp);
     }
+
+    @Override
+    public Config loadConfig(OptionSet options) {
 
 Review comment:
   Do you feel that the "base" use case for `CommandLine` is to need the full config? To me, it looks a little awkward to need to override `loadConfig` here with an implementation which is almost the same as the base `loadConfig`.
   I suppose one alternative would be to make this impl here the base impl, and then have each use case call `ConfigUtil.loadConfig` if is needs it. What do you see as the tradeoffs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services