You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2017/02/23 10:10:59 UTC

[GitHub] brooklyn-server pull request #338: Support nested catalog item definitions -...

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r102679601
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java ---
    @@ -65,7 +68,7 @@
         
         private final Class<? extends T> type;
         private String displayName;
    -    private String catalogItemId;
    --- End diff --
    
    surely I take this into account already? See testRebindWithCatalogAndAppRebindCatalogItemIds,
    and BrooklynMementoPersisterToObjectStore.getCatalogItemIds().
    
    Could add it back but maybe don't need to?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---