You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2008/07/29 15:14:33 UTC

[jira] Created: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
------------------------------------------------------------------------------------------------------------------------

                 Key: HADOOP-3852
                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
             Project: Hadoop Core
          Issue Type: Improvement
          Components: util
    Affects Versions: 0.19.0
            Reporter: Steve Loughran
            Priority: Minor


It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
* a toString() operator on the class that includes the list of arguments (when non null)
* a test that this works with arguments with spaces, and a null array
* relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated HADOOP-3852:
-----------------------------------

    Status: Patch Available  (was: Open)

with this patch, you get enough output in the log to replicate problems, such as:

08/07/29 14:16:54 [Thread-148] WARN mapred.TaskRunner : attempt_200807291416_0001_m_000002_0 Child Error
java.io.IOException: Task process exit with nonzero status of 1: bash -c "'ulimit' '-v' '786432' ;exec '/usr/java/jrockit-1.6.0_02/jre/bin/java' '-Djava.library.path=/usr/java/jrockit-1.6.0_02/jre/lib/amd64/jrockit:/usr/java/jrockit-1.6.0_02/jre/lib/amd64:/usr/java/jrockit-1.6.0_02/jre/../lib/amd64:/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/mapred/local/1_0/taskTracker/jobcache/job_200807291416_0001/attempt_200807291416_0001_m_000002_0/work' '-Xmx200m' '-Djava.io.tmpdir=/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/mapred/local/1_0/taskTracker/jobcache/job_200807291416_0001/attempt_200807291416_0001_m_000002_0/work/tmp' '-classpath' '/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test:/home/slo/Java/Apache/hadoop-core/build/test/classes:/home/slo/Java/Apache/hadoop-core/src/contrib/test:/home/slo/Java/Apache/hadoop-core/conf:/home/slo/Java/Apache/hadoop-core/build:/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/examples:/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/classes:/home/slo/Java/Apache/hadoop-core/build/classes:/home/slo/Java/Apache/hadoop-core/lib/commons-cli-2.0-SNAPSHOT.jar:/home/slo/Java/Apache/hadoop-core/lib/commons-codec-1.3.jar:/home/slo/Java/Apache/hadoop-core/lib/commons-httpclient-3.0.1.jar:/home/slo/Java/Apache/hadoop-core/lib/commons-logging-1.0.4.jar:/home/slo/Java/Apache/hadoop-core/lib/commons-logging-api-1.0.4.jar:/home/slo/Java/Apache/hadoop-core/lib/commons-net-1.4.1.jar:/home/slo/Java/Apache/hadoop-core/lib/jets3t-0.6.0.jar:/home/slo/Java/Apache/hadoop-core/lib/jetty-5.1.4.jar:/home/slo/Java/Apache/hadoop-core/lib/jetty-ext/commons-el.jar:/home/slo/Java/Apache/hadoop-core/lib/jetty-ext/jasper-compiler.jar:/home/slo/Java/Apache/hadoop-core/lib/jetty-ext/jasper-runtime.jar:/home/slo/Java/Apache/hadoop-core/lib/jetty-ext/jsp-api.jar:/home/slo/Java/Apache/hadoop-core/lib/junit-3.8.1.jar:/home/slo/Java/Apache/hadoop-core/lib/kfs-0.1.3.jar:/home/slo/Java/Apache/hadoop-core/lib/log4j-1.2.13.jar:/home/slo/Java/Apache/hadoop-core/lib/oro-2.0.8.jar:/home/slo/Java/Apache/hadoop-core/lib/servlet-api.jar:/home/slo/Java/Apache/hadoop-core/lib/slf4j-api-1.4.3.jar:/home/slo/Java/Apache/hadoop-core/lib/slf4j-log4j12-1.4.3.jar:/home/slo/Java/Apache/hadoop-core/lib/xmlenc-0.52.jar:/home/slo/Java/Apache/ant/lib/junit-3.8.2.jar:/home/slo/Java/Apache/ant/lib/ant-launcher.jar:/home/slo/Java/Apache/ant/lib/ant.jar:/home/slo/Java/Apache/ant/lib/ant-junit.jar::/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/mapred/local/1_0/taskTracker/jobcache/job_200807291416_0001/jars/classes:/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/mapred/local/1_0/taskTracker/jobcache/job_200807291416_0001/jars:/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/mapred/local/1_0/taskTracker/jobcache/job_200807291416_0001/attempt_200807291416_0001_m_000002_0/work' '-Dhadoop.log.dir=/home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/logs' '-Dhadoop.root.logger=INFO,TLA' '-Dhadoop.tasklog.taskid=attempt_200807291416_0001_m_000002_0' '-Dhadoop.tasklog.totalLogFileSize=0' 'org.apache.hadoop.mapred.TaskTracker$Child' '127.0.0.1' '52117' 'attempt_200807291416_0001_m_000002_0'  < /dev/null  1>> /home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/logs/userlogs/attempt_200807291416_0001_m_000002_0/stdout 2>> /home/slo/Java/Apache/hadoop-core/build/contrib/streaming/test/logs/userlogs/attempt_200807291416_0001_m_000002_0/stderr" 
	at org.apache.hadoop.mapred.TaskRunner.runChild(TaskRunner.java:461)
	at org.apache.hadoop.mapred.TaskRunner.run(TaskRunner.java:403)


> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624700#action_12624700 ] 

Hudson commented on HADOOP-3852:
--------------------------------

Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-3852:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.19.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Steve!

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated HADOOP-3852:
-----------------------------------

    Attachment: hadoop-3852.patch

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley reassigned HADOOP-3852:
-------------------------------------

    Assignee: Steve Loughran

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617810#action_12617810 ] 

Hadoop QA commented on HADOOP-3852:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12387093/hadoop-3852.patch
  against trunk revision 680577.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/console

This message is automatically generated.

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.