You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "loserwang1024 (via GitHub)" <gi...@apache.org> on 2024/08/19 10:09:42 UTC
[PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]
loserwang1024 opened a new pull request, #3556:
URL: https://github.com/apache/flink-cdc/pull/3556
As discussed in https://issues.apache.org/jira/browse/FLINK-36076 , Current, we apply schema change asynchronous.
SchemaChangeThreadPool will set isSchemaChangeApplying as true when apply schema change event. And the main thread which handle operater event will check isSchemaChangeApplying.
For thread safe, this should be volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #3556:
URL: https://github.com/apache/flink-cdc/pull/3556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on code in PR #3556:
URL: https://github.com/apache/flink-cdc/pull/3556#discussion_r1721785897
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java:
##########
@@ -94,7 +94,7 @@ public class SchemaRegistryRequestHandler implements Closeable {
private final Set<Integer> flushedSinkWriters;
/** Status of the execution of current schema change request. */
- private boolean isSchemaChangeApplying;
+ private transient boolean isSchemaChangeApplying;
Review Comment:
volatile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]
Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang commented on PR #3556:
URL: https://github.com/apache/flink-cdc/pull/3556#issuecomment-2296334567
The PR title and commit content confuse me a little, @loserwang1024 could you check your PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36076] Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. [flink-cdc]
Posted by "loserwang1024 (via GitHub)" <gi...@apache.org>.
loserwang1024 commented on PR #3556:
URL: https://github.com/apache/flink-cdc/pull/3556#issuecomment-2296197138
@leonardBang @PatrickRen @ruanhang1993 , CC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org