[GitHub] [incubator-nuttx] davids5 opened a new pull request, #6813: Kinetis EDMA update

[GitBox <gi...@apache.org>]

davids5 opened a new pull request, #6813:
URL: https://github.com/apache/incubator-nuttx/pull/6813

   ## Summary
   
   This PR cleans up the Kinetis EDMA code and makes it functional
   
   1. Header file clean up
   2. HW TCD reset of DLASTSGA is 32 Bits.
   3. HW TCD definition now matches HW.
   4. Fixed initialization so the kinetis_dmach_getcount reports 0 when Done.
   5. TCD has to be 32 byte aligned to work with Scatter Gather
   6. ttype was removed - it was used to apply dcache operation on external buffers, but the API does not know the buffer extent, so it is better to do the dcache operations in the code that owns the buffers.
   7. Support was updated for source or destination looping. Useful for non binary or large sided circular buffers.
   8. Added Interrupt on Half or Major loop completion.
   9. Scatters gather supports Single interrupt at the end.
   10. Order of operations on the HW TCD were corrected.
   11. DMA Termination order of operations changed to be able to get meaningful status on DMA completion or Error
   12. DMAMUX selection left disabled until used
   
    ## Impact
   
   Should be none. 
   
   ## Testing
   
   PX4 nxp_fmuk66-e
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6813: Kinetis EDMA update

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6813:
URL: https://github.com/apache/incubator-nuttx/pull/6813#discussion_r940561035


##########
arch/arm/src/kinetis/kinetis_edma.c:
##########
@@ -636,7 +610,15 @@ static int kinetis_edma_interrupt(int irq, void *context, void *arg)
 
       /* Terminate the transfer when it is done. */
 
-      kinetis_dmaterminate(dmach, result);
+      if ((dmach->flags & EDMA_CONFIG_LOOP_MASK) == 0)
+        {
+          kinetis_dmaterminate(dmach, result);
+        }
+      else if (dmach->callback != NULL)
+            {
+              dmach->callback((DMACH_HANDLE)dmach, dmach->arg,
+                              true, result);
+            }

Review Comment:
   please remove few spaces



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6813: Kinetis EDMA update

[GitBox <gi...@apache.org>]

xiaoxiang781216 merged PR #6813:
URL: https://github.com/apache/incubator-nuttx/pull/6813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org