[GitHub] [calcite] hsyuan commented on a change in pull request #1737: [CALCITE-3718] Support Intersect and Minus in Bindables

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1737:
URL: https://github.com/apache/calcite/pull/1737#discussion_r419492630



##########
File path: core/src/main/java/org/apache/calcite/interpreter/Bindables.java
##########
@@ -518,28 +522,36 @@ public Node implement(InterpreterImplementor implementor) {
   }
 
   /**
-   * Rule to convert an {@link org.apache.calcite.rel.logical.LogicalUnion}
-   * to a {@link BindableUnion}.
+   * Rule to convert an {@link SetOp} to a {@link BindableUnion}
+   * or {@link BindableIntersect} or {@link BindableMinus}.
    */
-  public static class BindableUnionRule extends ConverterRule {
+  public static class BindableSetOpRule extends ConverterRule {
 
     /**

Review comment:
       Can you add something like this?
   ```java
   @Deprecate // use BindableSetOpRule instead
   public static class BindableUnionRule extends BindableSetOpRule {}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org